Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts mashlib’s local development/build setup for SolidOS workspace development and addresses a type-compatibility issue when wiring solid-logic’s store into solid-panes.
Changes:
- Extend webpack workspace aliasing to include
solid-logic/SolidLogicand modify how the resolution mode is selected. - Update databrowser bootstrapping to cast the
solid-logicstore to the parameter type expected bypanes.initMainPageto avoid TypeScript type identity conflicts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
webpack.config.mjs |
Adds workspace aliases for solid-logic/SolidLogic and changes default resolution-mode selection logic. |
src/index.ts |
Adds a typed cast wrapper when calling panes.initMainPage with the SolidLogic store. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+34
to
+35
| const isDevServeOrWatch = Boolean(process.env.WEBPACK_SERVE || process.argv.includes('--watch')) | ||
| const resolutionMode = env.resolutionMode || process.env.MASHLIB_RESOLUTION_MODE || (isDevServeOrWatch ? WORKSPACE_RESOLUTION_MODE : PACKAGE_RESOLUTION_MODE) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit package vs workspace webpack resolution modes for local linked SolidOS development
Keep default npm/package builds unchanged while adding build:workspace, watch:workspace, and start:workspace
Fix GitHub Pages chunk loading by making webpack publicPath environment-driven
Add a dedicated build:ghpages script for the /mashlib/dist/ deployment path
Update CI to build the correct artifact for Pages without affecting published package builds