Matter Switch: Use defaults bounds if any custom bound is missing#2877
Open
hcarter-775 wants to merge 2 commits intomainfrom
Open
Matter Switch: Use defaults bounds if any custom bound is missing#2877hcarter-775 wants to merge 2 commits intomainfrom
hcarter-775 wants to merge 2 commits intomainfrom
Conversation
hcarter-775
requested review from
ctowns,
gharveymn,
nickolas-deboom and
tpmanley
|
Invitation URL: |
Test Results 72 files 494 suites 0s ⏱️ Results for commit e7129f4. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against e7129f4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
In the StatelessColorTemperatureStep command, we read the bounds or use defaults. However, since the colorTemperature capability's colorTemperatureRange attribute is only set after both custom bounds are, we should actually use the default bounds if any custom bound is missing to avoid "out of range" errors.
tag-along update: use hardcoded mired fields to avoid messy and unecessary rounding in the fields file
Follow-up discussion may be worthwhile to set the colorTemperatureRange if even one bound is present.
Summary of Completed Tests