add MultiIR Smart button MIR-SO100#2862
Open
thinkaName wants to merge 1 commit intoSmartThingsCommunity:mainfrom
Open
add MultiIR Smart button MIR-SO100#2862thinkaName wants to merge 1 commit intoSmartThingsCommunity:mainfrom
thinkaName wants to merge 1 commit intoSmartThingsCommunity:mainfrom
Conversation
|
Invitation URL: |
Test Results 72 files 500 suites 0s ⏱️ Results for commit 5804f79. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 5804f79 |
aleclorimer
reviewed
Apr 9, 2026
|
|
||
| zigbee_test_utils.prepare_zigbee_env_info() | ||
| local function test_init() | ||
| test.mock_device.add_test_device(mock_device)end |
aleclorimer
reviewed
Apr 9, 2026
Comment on lines
+26
to
+35
| local function added_handler(self, device) | ||
| device:emit_event(capabilities.button.supportedButtonValues({"pushed","double","held"}, {visibility = { displayed = false }})) | ||
| device:emit_event(capabilities.button.numberOfButtons({value = 1}, {visibility = { displayed = false }})) | ||
| button_utils.emit_event_if_latest_state_missing(device, "main", capabilities.button, capabilities.button.button.NAME, capabilities.button.button.pushed({state_change = false})) | ||
| end | ||
|
|
||
| local MultiIR_Emergency_Button = { | ||
| NAME = "MultiIR Emergency Button", | ||
| lifecycle_handlers = { | ||
| added = added_handler, |
Contributor
There was a problem hiding this comment.
You can delete the added_handler function and use ours defined here. If the device doesn't support the TemperatureMeasurement cluster, then it will functionally be the same and simplify the driver.
aleclorimer
reviewed
Apr 9, 2026
| test.socket.capability:__expect_send( | ||
| mock_device:generate_test_message( | ||
| "main", | ||
| capabilities.button.supportedButtonValues({ "pushed","double","held" }, { visibility = { displayed = false } }) |
Contributor
There was a problem hiding this comment.
Suggested change
| capabilities.button.supportedButtonValues({ "pushed","double","held" }, { visibility = { displayed = false } }) | |
| capabilities.button.supportedButtonValues({ "pushed","held","double" }, { visibility = { displayed = false } }) |
To line up with our default added_handler
aleclorimer
reviewed
Apr 9, 2026
| test.socket.capability:__expect_send( | ||
| mock_device:generate_test_message( | ||
| "main", | ||
| capabilities.button.supportedButtonValues({ "pushed","double","held" }, { visibility = { displayed = false } }) |
Contributor
There was a problem hiding this comment.
Suggested change
| capabilities.button.supportedButtonValues({ "pushed","double","held" }, { visibility = { displayed = false } }) | |
| capabilities.button.supportedButtonValues({ "pushed","held","double" }, { visibility = { displayed = false } }) |
To line up with our default added_handler
thinkaName
force-pushed
the
multiir_smart_button_MIR-SO100
branch
from
090ac00 to
5804f79
Compare
aleclorimer
approved these changes
Apr 10, 2026
aleclorimer
reviewed
Apr 10, 2026
|
|
||
| local zcl_clusters = require "st.zigbee.zcl.clusters" | ||
| local capabilities = require "st.capabilities" | ||
| local button_utils = require "button_utils" |
Contributor
There was a problem hiding this comment.
luacheck: Remove this and it should be good to go
aleclorimer
reviewed
Apr 10, 2026
|
|
||
| local IASZone = clusters.IASZone | ||
|
|
||
| local button_attr = capabilities.button.button |
Contributor
There was a problem hiding this comment.
luacheck: Remove this line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests