WWSTCERT-8045 - Aeotec Home Energy Meter Gen8 (Revert + fixes)

[KKlimczukS]

WWSTCERT-8045 - Aeotec Home Energy Meter Gen8
cleanup + fixes

[github-actions]

Duplicate profile check: Passed - no duplicate profiles detected.

[github-actions]

Channel deleted.

[github-actions]

Test Results

   72 files    497 suites   0s ⏱️
2 721 tests 2 721 ✅ 0 💤 0 ❌
4 631 runs  4 631 ✅ 0 💤 0 ❌

Results for commit 8707171.

♻️ This comment has been updated with latest results.

[github-actions]

File	Coverage
All files	98%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-electric-meter/src/preferences.lua	97%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-electric-meter/src/lazy_load_subdriver.lua	57%	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-electric-meter/src/aeotec-home-energy-meter-gen8/init.lua	88%	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-electric-meter/src/aeotec-home-energy-meter-gen8/power_consumption.lua	94%	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 8707171

[greens]

@KKlimczukS are you open to making changes to this PR beyond the updates?

[greens]

There seems to be a lot of overlap between the three sub-drivers that could be pulled up into the parent. As far as I can tell the only difference between 2-phase and 3-phase are the endpoints used for meter reports and the fingerprints. I didn't check 1-phase but assume it is similar. Also please shorten the copyright/license statement to the new format.

[KKlimczukS]

There seems to be a lot of overlap between the three sub-drivers that could be pulled up into the parent. As far as I can tell the only difference between 2-phase and 3-phase are the endpoints used for meter reports and the fingerprints. I didn't check 1-phase but assume it is similar. Also please shorten the copyright/license statement to the new format.

@greens

• I moved several duplicated functions to the parent,
• supporting powerConsumptionEvents was moved to a separate file
• The rest of the code relies on HEM8_DEVICES tables - those keep data strictly related to specific version of the device, so those need to stay in sub-sub-drivers, otherwise further refactoring might basically flatten the whole structure