Add vid/pid of the Schlage Sense Pro to new-matter-lock#2748
Add vid/pid of the Schlage Sense Pro to new-matter-lock#2748nickolas-deboom merged 1 commit intomainfrom
Conversation
|
Channel deleted. |
Test Results 72 files 485 suites 0s ⏱️ Results for commit 2779abc. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 2779abc |
| {0x10E1, 0x2002}, -- VDA | ||
| {0x1421, 0x0042}, -- Kwikset Halo Select Plus | ||
| {0x1421, 0x0081}, -- Kwikset Aura Reach | ||
| {0x1236, 0xa538}, -- Kwikset Aura Reach |
There was a problem hiding this comment.
The DCL lists 0x3800 for the Schlage Sense Pro - is this pid correct or is this a different model?
| {0x10E1, 0x2002}, -- VDA | ||
| {0x1421, 0x0042}, -- Kwikset Halo Select Plus | ||
| {0x1421, 0x0081}, -- Kwikset Aura Reach | ||
| {0x1236, 0xa538}, -- Kwikset Aura Reach |
There was a problem hiding this comment.
| {0x1236, 0xa538}, -- Kwikset Aura Reach | |
| {0x1236, 0xa538}, -- Schlage Sense Pro |
There was a problem hiding this comment.
You are right. Thank you for checking.
|
Hey @HunsupJung, would you mind rebasing and see if that gets the CI to pass? Also, I had one comment about the PID of this device, could you confirm that 0xa538 is correct? I'm sure it is but I noticed that there is a Schlage Sense Pro in the DCL with a PID of 0x3800 so I wanted to confirm. |
Hi @nickolas-deboom , |
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
595f910 to
2779abc
Compare
Thanks for checking that! I rebased it and will merge. |
Type of Change
Checklist
Description of Change
Summary of Completed Tests