Skip to content

Add vid/pid of the Schlage Sense Pro to new-matter-lock#2748

Merged
nickolas-deboom merged 1 commit intomainfrom
feature/add-schlage-lock
Feb 12, 2026
Merged

Add vid/pid of the Schlage Sense Pro to new-matter-lock#2748
nickolas-deboom merged 1 commit intomainfrom
feature/add-schlage-lock

Conversation

@HunsupJung
Copy link
Collaborator

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Channel deleted.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Test Results

   72 files    485 suites   0s ⏱️
2 518 tests 2 518 ✅ 0 💤 0 ❌
4 333 runs  4 333 ✅ 0 💤 0 ❌

Results for commit 2779abc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

File Coverage
All files 72%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/can_handle.lua 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 64%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lazy_load_subdriver.lua 57%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 98%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 2779abc

{0x10E1, 0x2002}, -- VDA
{0x1421, 0x0042}, -- Kwikset Halo Select Plus
{0x1421, 0x0081}, -- Kwikset Aura Reach
{0x1236, 0xa538}, -- Kwikset Aura Reach
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DCL lists 0x3800 for the Schlage Sense Pro - is this pid correct or is this a different model?

{0x10E1, 0x2002}, -- VDA
{0x1421, 0x0042}, -- Kwikset Halo Select Plus
{0x1421, 0x0081}, -- Kwikset Aura Reach
{0x1236, 0xa538}, -- Kwikset Aura Reach
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{0x1236, 0xa538}, -- Kwikset Aura Reach
{0x1236, 0xa538}, -- Schlage Sense Pro

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Thank you for checking.

Copy link
Contributor

@Kwang-Hui Kwang-Hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@nickolas-deboom
Copy link
Contributor

Hey @HunsupJung, would you mind rebasing and see if that gets the CI to pass? Also, I had one comment about the PID of this device, could you confirm that 0xa538 is correct? I'm sure it is but I noticed that there is a Schlage Sense Pro in the DCL with a PID of 0x3800 so I wanted to confirm.

@Kwang-Hui
Copy link
Contributor

Hey @HunsupJung, would you mind rebasing and see if that gets the CI to pass? Also, I had one comment about the PID of this device, could you confirm that 0xa538 is correct? I'm sure it is but I noticed that there is a Schlage Sense Pro in the DCL with a PID of 0x3800 so I wanted to confirm.

Hi @nickolas-deboom ,
Hunsup is OOO now. I can confirm - behalf of him - that the PID is corrent.
I don't have access to rebase this PR. but is it possible from your side?

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
@nickolas-deboom nickolas-deboom force-pushed the feature/add-schlage-lock branch from 595f910 to 2779abc Compare February 12, 2026 01:41
@nickolas-deboom
Copy link
Contributor

Hey @HunsupJung, would you mind rebasing and see if that gets the CI to pass? Also, I had one comment about the PID of this device, could you confirm that 0xa538 is correct? I'm sure it is but I noticed that there is a Schlage Sense Pro in the DCL with a PID of 0x3800 so I wanted to confirm.

Hi @nickolas-deboom , Hunsup is OOO now. I can confirm - behalf of him - that the PID is corrent. I don't have access to rebase this PR. but is it possible from your side?

Thanks for checking that! I rebased it and will merge.

@nickolas-deboom nickolas-deboom merged commit 06a48f6 into main Feb 12, 2026
11 checks passed
@nickolas-deboom nickolas-deboom deleted the feature/add-schlage-lock branch February 12, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants