Add Spring.after_environment_load hook for post-Rails preloading#1
Closed
Add Spring.after_environment_load hook for post-Rails preloading#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
Spring.after_environment_loadhook that runs immediately after the Rails application environment is loaded in the Spring server process, but beforeGC.compact/Process.warmupand before the server enters its wait loop.This hook enables applications to preload expensive test infrastructure (e.g. test helpers, fixture caches, datastore connections) into the Spring server so that forked test workers inherit that work via copy-on-write instead of paying it on every invocation.
API
The block receives no arguments and runs once per server boot. It is intentionally not called when Spring is disabled or when the environment is reloaded.
Motivation
In Shopify's monorepo,
bin/testpays ~2.4s ofrequirecost forplatform/testing/test_helperon every test run even with Spring hot. By preloading this file into the Spring server, forked workers inherit the already-required code via CoW, reducing time-to-first-test significantly for inner-loop development.Implementation
Spring::Configurationgains an@after_environment_loadarray andafter_environment_loadregistration method (same pattern asafter_fork).Spring::Application#load_applicationcalls the callbacks afterrequire app_envreturns.