Migrate find references to Rubydex#4066
Merged
vinistock merged 4 commits intorubydex_adoption_feature_branchfrom Apr 30, 2026
Merged
Migrate find references to Rubydex#4066vinistock merged 4 commits intorubydex_adoption_feature_branchfrom
vinistock merged 4 commits intorubydex_adoption_feature_branchfrom
Conversation
vinistock
added
server
19 tasks
vinistock
force-pushed
the
vs_fix_node_context_for_methods_with_receivers
branch
from
338eeee to
4c1f108
Compare
vinistock
force-pushed
the
vs_migrate_find_references_to_rubydex
branch
from
3586cfd to
d336389
Compare
vinistock
force-pushed
the
vs_fix_node_context_for_methods_with_receivers
branch
from
4c1f108 to
9846ab4
Compare
vinistock
force-pushed
the
vs_migrate_find_references_to_rubydex
branch
from
d336389 to
9f72010
Compare
Morriar
reviewed
Apr 28, 2026
vinistock
force-pushed
the
vs_fix_node_context_for_methods_with_receivers
branch
from
9846ab4 to
c753e32
Compare
vinistock
force-pushed
the
vs_migrate_find_references_to_rubydex
branch
from
9f72010 to
dcc6d98
Compare
vinistock
force-pushed
the
vs_fix_node_context_for_methods_with_receivers
branch
from
c753e32 to
2cb06f8
Compare
vinistock
force-pushed
the
vs_fix_node_context_for_methods_with_receivers
branch
from
2cb06f8 to
b6b596d
Compare
vinistock
force-pushed
the
vs_migrate_find_references_to_rubydex
branch
from
dcc6d98 to
1d78a19
Compare
Morriar
approved these changes
Apr 30, 2026
Base automatically changed from
vs_fix_node_context_for_methods_with_receivers
to
rubydex_adoption_feature_branch
April 30, 2026 19:00
vinistock
merged commit 2ace51b
into
rubydex_adoption_feature_branch
52 of 53 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Migrate find references to use Rubydex. There are two things missing, which I encoded in the tests:
Implementation
I migrated the request in a way that it's already prepared to account for instance, class and global variables as soon as we add support for it in Rubydex.
Automated Tests
Added a bunch of new tests trying to encode all sorts of behaviours that the previous ones didn't. For example: