Adjust store auth warning for non-canonical store domain#7150
Merged
isaacroldan merged 1 commit intomainfrom Apr 2, 2026
Merged
Adjust store auth warning for non-canonical store domain#7150isaacroldan merged 1 commit intomainfrom
isaacroldan merged 1 commit intomainfrom
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
RyanDJLee
approved these changes
Apr 1, 2026
00cbcd2 to
0d60e8d
Compare
03a1517 to
3bbda17
Compare
ryancbahan
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Improve the
shopify store authcallback-store mismatch error so it points the user at the permanent store domain Shopify returned during authentication.Why
Some stores can start auth on one domain and return a different canonical
.myshopify.comdomain in the OAuth callback. Today that fails with a generic store-mismatch error, which makes it hard to tell whether the issue is an alias or vanity domain.This change keeps the existing callback validation but makes the next step explicit.
How
shopparameter does not match the requested storeshopify store authwith the permanent store domain instead of an alias or vanity domainTesting
To test manually:
shopify store auth --store <alias-or-vanity-domain> --scopes read_productsMeasuring impact
How do we know this change was effective? Please choose one:
Checklist