Skip to content

E2E: infra refactor + app tests update #7147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phyllis-sy-wu wants to merge 3 commits into
base: main
Choose a base branch
from
Open

E2E: infra refactor + app tests update #7147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f65a038
E2E: infra refactor + app tests update
phyllis-sy-wu Apr 1, 2026
b5e199a
refactor to address review feedback
phyllis-sy-wu Apr 2, 2026
de26577
rename cleanupApp → teardownApp
phyllis-sy-wu Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/tests-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ jobs:
E2E_ACCOUNT_PASSWORD: ${{ secrets.E2E_ACCOUNT_PASSWORD }}
E2E_STORE_FQDN: ${{ secrets.E2E_STORE_FQDN }}
E2E_SECONDARY_CLIENT_ID: ${{ secrets.E2E_SECONDARY_CLIENT_ID }}
E2E_ORG_ID: ${{ secrets.E2E_ORG_ID }}
run: npx playwright test
- name: Upload Playwright report
uses: actions/upload-artifact@v4
Expand Down
1 change: 1 addition & 0 deletions packages/e2e/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"devDependencies": {
"@playwright/test": "^1.50.0",
"@types/node": "18.19.70",
"dotenv": "16.4.7",
"execa": "^7.2.0",
"node-pty": "^1.0.0",
"strip-ansi": "^7.1.0",
Expand Down
21 changes: 2 additions & 19 deletions packages/e2e/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,8 @@
/* eslint-disable line-comment-position */
/* eslint-disable no-restricted-imports */
import {config} from 'dotenv'
import {defineConfig} from '@playwright/test'
import * as fs from 'fs'
import * as path from 'path'
import {fileURLToPath} from 'url'

const __dirname = path.dirname(fileURLToPath(import.meta.url))

// Load .env file if present (CI provides env vars directly)
const envPath = path.join(__dirname, '.env')
if (fs.existsSync(envPath)) {
for (const line of fs.readFileSync(envPath, 'utf-8').split('\n')) {
const trimmed = line.trim()
if (!trimmed || trimmed.startsWith('#')) continue
const eqIdx = trimmed.indexOf('=')
if (eqIdx === -1) continue
const key = trimmed.slice(0, eqIdx).trim()
const value = trimmed.slice(eqIdx + 1).trim()
process.env[key] ??= value
}
}
config()

const isCI = Boolean(process.env.CI)

Expand Down
Loading
Loading