Skip to content

Add user aborted a request to errorMessageImpliesEnvironmentIssue#7145

Merged
isaacroldan merged 1 commit intomainfrom
04-01-add_user_aborted_a_request_to_errormessageimpliesenvironmentissue
Apr 2, 2026
Merged

Add user aborted a request to errorMessageImpliesEnvironmentIssue#7145
isaacroldan merged 1 commit intomainfrom
04-01-add_user_aborted_a_request_to_errormessageimpliesenvironmentissue

Conversation

@lucyxiang
Copy link
Copy Markdown
Contributor

@lucyxiang lucyxiang commented Apr 1, 2026

WHY are these changes introduced?

We should not send to observe errors relating to user aborting a request

Don't add a changeset as this is not user facing or noteable (happy to add one if you think otherwise)

Fixes https://observe.shopify.io/a/observe/errors?r=%7B%22from%22%3A%22now-30d%22%2C%22to%22%3A%22now%22%7D&tz=browser&f=%7B%22resource.service.name%22%3A%5B%22cli%22%5D%2C%22slice_name%22%3A%5B%5D%7D&n=The+user+aborted+a+request&au=1

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lucyxiang lucyxiang marked this pull request as ready for review April 1, 2026 17:11
@lucyxiang lucyxiang requested a review from a team as a code owner April 1, 2026 17:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

Copy link
Copy Markdown
Contributor

@isaacroldan isaacroldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct, this error message indicates a network timeout.

@isaacroldan isaacroldan added this pull request to the merge queue Apr 2, 2026
Merged via the queue into main with commit e24b4a2 Apr 2, 2026
27 checks passed
@isaacroldan isaacroldan deleted the 04-01-add_user_aborted_a_request_to_errormessageimpliesenvironmentissue branch April 2, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants