Skip to content

Fix admin URL for local core: add 'admin' to NON_SHOP_PREFIXES #7137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craigmichaelmartin merged 1 commit into from
Apr 2, 2026
Merged

Fix admin URL for local core: add 'admin' to NON_SHOP_PREFIXES #7137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli-kit/src/public/node/vendor/dev_server/dev-server-2024.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import fs from 'node:fs'

import type {HostOptions} from './types.js'

const NON_SHOP_PREFIXES = ['app', 'dev', 'shopify']
const NON_SHOP_PREFIXES = ['admin', 'app', 'dev', 'shopify']
Copy link
Copy Markdown
Contributor Author

@craigmichaelmartin craigmichaelmartin Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, just noticed this file is in node/vendor 🤔

Copy link
Copy Markdown
Contributor

@isaacroldan isaacroldan Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the fix makes sense (didn't tophat), but we need to check if we need to update this vendored file

Copy link
Copy Markdown
Contributor Author

@craigmichaelmartin craigmichaelmartin Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, already merged.

const BACKEND_PORT = 8080

/**
Expand Down
Loading