Open
Conversation
gregdodd
approved these changes
Apr 30, 2026
6f348d3 to
fb167a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minitest 6.0 shipped breaking API changes that affect ci-queue. This PR adds minitest 6 support while remaining backwards compatible with minitest 5.11+.
Breaking changes in minitest 6
1.
Minitest.run_one_method(klass, name)— removedci-queue used this to run individual tests in
SingleExample#runandLazySingleExample#run. Replaced withklass.new(name).runwhich works on both minitest 5 and 6.2.
Minitest.__run— renamed toMinitest.run_all_suitesci-queue prepends a module onto
Minitest's singleton class to override__runwith its Redis-backed poll loop. minitest 6 renamed this method, so the override no longer fires. We now define both__runandrun_all_suiteson the prepended module — only the one matching the active minitest version is called;the other is inert.
3. Plugin loading — now opt-in
minitest 5 auto-discovered plugins via
load_pluginsinsideMinitest.run. minitest 6 removed this. Without it,minitest-reporters'plugin_minitest_reporter_initnever fires, so itsDelegateReporteris never created. This meant ci-queue's reporters (includingBuildStatusRecorder) were set inMinitest::Reporters.reportersbut never wired into theCompositeReporterthatMinitest.runactually callsrecordon.The consequence:
BuildStatusRecorder#recordnever ran →acknowledgenever called → Redis running set never cleared →exhausted?never returned true → the poll loop hung forever.Fixed by calling
Minitest.load_pluginsexplicitly when ci-queue sets up its reporters, and inrun_tests_in_fork(used by bisect).4.
Parallel::Executorthread poolminitest 6 starts N threads (where N = CPU count) before
run_all_suitesand joins them afterward viashutdown. ci-queue bypasses the executor entirely — it has its own Redis poll loop — so those threads sit idle onqueue.popandshutdownblocks forever. We now drain the executor afterQueue.runcompletes.
Backwards compatibility
All changes are guarded by
respond_to?checks. No version string comparisons. minitest 5.11+ continues to work unchanged.