Make HeartbeatProcess#tick! lease argument backward-compatible#405
Closed
Make HeartbeatProcess#tick! lease argument backward-compatible#405
Conversation
acaron
force-pushed
the
fix-tick-backward-compat
branch
6 times, most recently
from
627b31a to
2d3b68d
Compare
The lease parameter was added to tick! in v0.85.0 but callers in the monolith (MultiTick#heartbeat) still use the old 1-arg signature. Make lease optional so existing callers work without changes. Bump ci-queue to v0.94.0.
acaron
force-pushed
the
fix-tick-backward-compat
branch
from
2d3b68d to
c425a30
Compare
acaron
commented
Apr 30, 2026
| end | ||
|
|
||
| def test_tick_does_not_allocate_tick_marker_string | ||
| @hp.instance_variable_set(:@pipe, FakePipe.new) |
Member
Author
There was a problem hiding this comment.
Adding PipedHeartbeatProcess to remove usage of instance_variable_set
ianks
requested changes
Apr 30, 2026
Contributor
ianks
left a comment
ianks
left a comment
There was a problem hiding this comment.
Shouldn't we just fix the callsite? it doesn't make much sense to have a nilable lease
Member
Author
|
Closing in favour of fixing callsite by fetching lease |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
leaseparameter was added toHeartbeatProcess#tick!in v0.85.0, changing the signature from 1 argument to 2. Callers still using the old 1-argument signature crash withArgumentError: wrong number of arguments (given 1, expected 2)when upgrading.Make
leaseoptional so both call sites work. When omitted,leaseis excluded from the heartbeat payload entirely, matching the pre-v0.85.0 wire format.Also cleans up
instance_variable_setusage in the heartbeat tests by introducing aPipedHeartbeatProcesstest subclass with proper constructor injection.co-authored by AI