Restore dual architecture support for 3.9#487
Open
kieran-osgood-shopify wants to merge 1 commit into
Open
Conversation
f6d38f0 to
8c2ef3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
@shopify/checkout-sheet-kitto the3.9.0line while preserving the v3 public async API.NativeModulesresolution.Validation
pnpm module typecheckpnpm module lintpnpm module buildpnpm sample typecheckpnpm test --watchman=false modules/@shopify/checkout-sheet-kit/tests./gradlew assembleDebug --no-daemon --console=plain -PreactNativeArchitectures=arm64-v8a -PnewArchEnabled=false./gradlew assembleDebug --no-daemon --console=plain -PreactNativeArchitectures=arm64-v8a -PnewArchEnabled=trueRCT_NEW_ARCH_ENABLED=0 bundle exec pod install --no-repo-updateplus generic simulatorxcodebuild clean buildRCT_NEW_ARCH_ENABLED=1 bundle exec pod install --no-repo-updateplus generic simulatorxcodebuild clean build