Skip to content

Restore dual architecture support for 3.9#487

Open
kieran-osgood-shopify wants to merge 1 commit into
mainfrom
kieran-osgood/cx-rn-v39-compat/dual-architecture
Open

Restore dual architecture support for 3.9#487
kieran-osgood-shopify wants to merge 1 commit into
mainfrom
kieran-osgood/cx-rn-v39-compat/dual-architecture

Conversation

@kieran-osgood-shopify
Copy link
Copy Markdown
Contributor

@kieran-osgood-shopify kieran-osgood-shopify commented May 13, 2026

What changes are you making?

  • Restores @shopify/checkout-sheet-kit to the 3.9.0 line while preserving the v3 public async API.
  • Keeps the JavaScript API compatible with both TurboModule and legacy NativeModules resolution.
  • Restores old/new architecture support on Android and iOS by gating codegen/new-arch dependencies and exporting legacy bridge Promise methods.
  • Updates docs, sample usage, and tests for the 3.9 dual-architecture migration release.

Validation

  • pnpm module typecheck
  • pnpm module lint
  • pnpm module build
  • pnpm sample typecheck
  • pnpm test --watchman=false modules/@shopify/checkout-sheet-kit/tests
  • Android sample old arch: ./gradlew assembleDebug --no-daemon --console=plain -PreactNativeArchitectures=arm64-v8a -PnewArchEnabled=false
  • Android sample new arch: ./gradlew assembleDebug --no-daemon --console=plain -PreactNativeArchitectures=arm64-v8a -PnewArchEnabled=true
  • iOS sample old arch: RCT_NEW_ARCH_ENABLED=0 bundle exec pod install --no-repo-update plus generic simulator xcodebuild clean build
  • iOS sample new arch: RCT_NEW_ARCH_ENABLED=1 bundle exec pod install --no-repo-update plus generic simulator xcodebuild clean build

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

Coverage Report

Lines Statements Branches Functions
Coverage: 99%
99.12% (227/229) 94.69% (125/132) 100% (68/68)

@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as ready for review May 13, 2026 09:07
@kieran-osgood-shopify kieran-osgood-shopify requested a review from a team as a code owner May 13, 2026 09:07
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/cx-rn-v39-compat/dual-architecture branch from f6d38f0 to 8c2ef3f Compare May 13, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant