Restore async public API for 3.9#486
Closed
kieran-osgood-shopify wants to merge 1 commit into
Closed
Conversation
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Restores the V3 Promise-returning JavaScript API while keeping the native New Architecture/TurboModule methods synchronous under the hood.
This also changes the release line from
4.0.0to3.9.0and updates the compatibility docs/Podfile lockfile to match.Why?
The native API moved from Promise callbacks to synchronous TurboModule methods, but publishing that as-is would break existing V3 consumers that
awaitgetConfig, accelerated checkout configuration, and availability checks.Wrapping the synchronous native calls at the JS facade preserves the existing public async semantics for the 3.9 line without reverting the native New Architecture work.
Validation
pnpm module typecheckpnpm module lintpnpm test --watchman=false modules/@shopify/checkout-sheet-kit/testspnpm module buildpnpm sample typecheckcd sample/ios && ../vendor/bundle/ruby/3.4.0/bin/pod install --no-repo-update