Remove New Arch interop checks - New Arch only by kieran-osgood-shopify · Pull Request #456 · Shopify/checkout-sheet-kit-react-native

kieran-osgood-shopify · 2026-03-30T14:26:53Z

What changes are you making?

Following on from the introduction of turbo specs in #449 this PR removes the existing fabric conditionals leaving only the new architecture enabled going forwards

PR Checklist

Important

I've added tests to support my implementation
I have read and agree with the Contribution Guidelines.
I have read and agree with the Code of Conduct.
I've updated the README.

Releasing a new version of the kit?

I have bumped the version number in the package.json file.

Tip

See the Contributing documentation for instructions on how to publish a new version of the library.

kieran-osgood-shopify · 2026-03-30T14:27:07Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-03-30T14:27:35Z

Coverage Report

Lines	Statements	Branches	Functions
	99.53% (214/215)	95.96% (119/124)	100% (64/64)

kieran-osgood-shopify · 2026-05-06T19:17:45Z

Merge activity

May 6, 7:17 PM UTC: A user started a stack merge that includes this pull request via Graphite.
May 6, 7:19 PM UTC: Graphite rebased this pull request as part of a merge.
May 6, 7:50 PM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (GitHub is reporting that this PR is not mergeable, despite passing required status checks defined by your branch protection rules. Please check your rulesets for additional blocking criteria. Graphite Merge Queue does not currently support rulesets. Please contact Graphite support for further assistance.).

…igration (#449) ### What changes are you making? This PR introduces TurboMobule specs and codegen but maintains the existing legacy compatability layer, which is removed in #456 There is no real behavioural differences in this PR - it just introduces the build layer step of compiling the TS specs into c++ --- ### PR Checklist > [!IMPORTANT] > > - [ ] I've added tests to support my implementation > - [ ] I have read and agree with the [Contribution Guidelines](https://github.com/shopify/checkout-sheet-kit-react-native/blob/main/.github/CONTRIBUTING.md). > - [ ] I have read and agree with the [Code of Conduct](https://github.com/shopify/checkout-sheet-kit-react-native/blob/main/.github/CODE_OF_CONDUCT.md). > - [ ] I've updated the [README](https://github.com/shopify/checkout-sheet-kit-react-native). > > _Releasing a new version of the kit?_ > > - [ ] I have bumped the version number in the [`package.json` file](https://github.com/Shopify/checkout-sheet-kit-react-native/blob/main/modules/%40shopify/checkout-sheet-kit/package.json#L4). --- > [!TIP] > See the [Contributing documentation](https://github.com/shopify/checkout-sheet-kit-react-native/blob/main/.github/CONTRIBUTING.md#releasing-a-new-version) for instructions on how to publish a new version of the library.

Now that we're on TurboModules, the four promise-based methods (getConfig, configureAcceleratedCheckouts, isAcceleratedCheckoutAvailable, isApplePayAvailable) can use synchronous JSI dispatch. Their native implementations are pure in-memory reads or state writes, so the Promise wrapper was boilerplate that blocked readable call sites. BREAKING CHANGE: Consumers must drop `await` from these calls. - Spec: return ConfigurationResultSpec / boolean directly instead of Promise - iOS Swift: remove resolve/reject, return NSDictionary / NSNumber - Android: annotate with isBlockingSynchronousMethod = true, return directly - Consumer API in src/index.ts and src/context.tsx: drop async / await - Tests: replace mockResolvedValue with mockReturnValue, drop awaits - Sample app: drop awaits in Cart and SettingsScreen Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The codegen spec returns colorScheme and logLevel as `string`, but the consumer-facing Configuration type uses typed enums. Replace the previous `as Configuration` cast with a parser that: - Validates colorScheme/logLevel against known enum values, falling back to the safest default when the native side returns an unrecognised value - Re-shapes the flat iOS color fields into the nested `colors.ios` shape so a round trip through setConfig preserves user overrides - Omits undefined fields so consumers don't see spurious `title: undefined` Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Swift tests were still calling the four converted methods with resolve/reject callbacks. Update them to call the sync API directly and compare against the returned NSNumber/NSDictionary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

This was referenced Mar 30, 2026

Add TurboModule specs and codegen components to prepare RN new-arch migration #449

Merged

chore: bump dev.yml to iOS 26.2 #448

Merged

kieran-osgood-shopify force-pushed the cx-rn-new-arch-plan branch from cc709d6 to f89b585 Compare April 14, 2026 11:58

kieran-osgood-shopify force-pushed the kieran-osgood/03-30-featreplaceinteropwithnewarchcode branch from 14eb240 to b78d8d1 Compare April 14, 2026 11:58

kieran-osgood-shopify mentioned this pull request Apr 16, 2026

feat!: bump to v4.0.0 (New Architecture Release) #467

Merged

3 tasks

kieran-osgood-shopify force-pushed the kieran-osgood/03-30-featreplaceinteropwithnewarchcode branch from b78d8d1 to ead781e Compare April 16, 2026 16:21

kieran-osgood-shopify marked this pull request as ready for review April 16, 2026 17:06

kieran-osgood-shopify requested a review from a team as a code owner April 16, 2026 17:06

kieran-osgood-shopify changed the title ~~feat: replace interop with new arch code~~ Remove New Arch interop checks - New Arch only Apr 17, 2026

kieran-osgood-shopify force-pushed the kieran-osgood/03-30-featreplaceinteropwithnewarchcode branch 5 times, most recently from 07d29f6 to ba34eac Compare April 17, 2026 09:16

kieran-osgood-shopify force-pushed the cx-rn-new-arch-plan branch from 995f1b1 to 068673a Compare April 17, 2026 09:22

kieran-osgood-shopify force-pushed the kieran-osgood/03-30-featreplaceinteropwithnewarchcode branch 2 times, most recently from 9c8a074 to 4be033f Compare April 17, 2026 09:31

kieran-osgood-shopify force-pushed the cx-rn-new-arch-plan branch from 068673a to 32a2485 Compare April 17, 2026 09:31

This was referenced Apr 17, 2026

Release 3.8.0: applePayStyle + Accelerated Checkouts StoreFront API 2026-04 #464

Merged

feat: bump ShopifyCheckoutSheetKit dependency to 3.7.0 #463

Merged

markmur reviewed Apr 17, 2026

View reviewed changes

Comment thread modules/@shopify/checkout-sheet-kit/RNShopifyCheckoutSheetKit.podspec Outdated

markmur approved these changes Apr 17, 2026

View reviewed changes

josemiguel-alvarez approved these changes Apr 17, 2026

View reviewed changes

tiagocandido approved these changes Apr 17, 2026

View reviewed changes

kieran-osgood-shopify force-pushed the cx-rn-new-arch-plan branch 2 times, most recently from fdb9158 to c99a638 Compare April 17, 2026 13:33

kieran-osgood-shopify force-pushed the kieran-osgood/03-30-featreplaceinteropwithnewarchcode branch 2 times, most recently from 83db6fb to d45eb12 Compare April 20, 2026 14:41

kieran-osgood-shopify force-pushed the kieran-osgood/03-30-featreplaceinteropwithnewarchcode branch from d45eb12 to fa18e5f Compare May 1, 2026 10:17

kieran-osgood-shopify force-pushed the cx-rn-new-arch-plan branch from c99a638 to f60bb00 Compare May 5, 2026 16:00

kieran-osgood-shopify force-pushed the kieran-osgood/03-30-featreplaceinteropwithnewarchcode branch 2 times, most recently from 0d43f55 to dc837d5 Compare May 5, 2026 17:17

kieran-osgood-shopify force-pushed the cx-rn-new-arch-plan branch 2 times, most recently from 62d1bcf to dee8e5c Compare May 5, 2026 17:52

kieran-osgood-shopify force-pushed the kieran-osgood/03-30-featreplaceinteropwithnewarchcode branch from dc837d5 to bf8dba6 Compare May 5, 2026 17:52

kieran-osgood-shopify mentioned this pull request May 5, 2026

fix: pin react-native-quick-crypto to 1.0.9 #480

Merged

kieran-osgood-shopify force-pushed the cx-rn-new-arch-plan branch 2 times, most recently from cd35500 to 5d96a31 Compare May 5, 2026 18:07

kieran-osgood-shopify force-pushed the kieran-osgood/03-30-featreplaceinteropwithnewarchcode branch from bf8dba6 to 6ddb3e2 Compare May 5, 2026 21:07

Juanita-Dash changed the base branch from cx-rn-new-arch-plan to graphite-base/456 May 6, 2026 18:07

Juanita-Dash force-pushed the graphite-base/456 branch from 5d96a31 to a3ed0f2 Compare May 6, 2026 18:07

Juanita-Dash changed the base branch from graphite-base/456 to main May 6, 2026 18:08

Juanita-Dash mentioned this pull request May 6, 2026

Rename Checkout Sheet Kit to Checkout Kit (React Native) #483

Closed

kieran-osgood-shopify changed the base branch from main to graphite-base/456 May 6, 2026 18:50

kieran-osgood-shopify force-pushed the kieran-osgood/03-30-featreplaceinteropwithnewarchcode branch from 6ddb3e2 to afba17f Compare May 6, 2026 18:50

kieran-osgood-shopify changed the base branch from graphite-base/456 to cx-rn-new-arch-plan May 6, 2026 18:51

kieran-osgood-shopify changed the base branch from cx-rn-new-arch-plan to graphite-base/456 May 6, 2026 19:17

kieran-osgood-shopify changed the base branch from graphite-base/456 to main May 6, 2026 19:18

kieran-osgood-shopify and others added 4 commits May 6, 2026 19:18

feat: replace interop with new arch code

f10e6c3

kieran-osgood-shopify force-pushed the kieran-osgood/03-30-featreplaceinteropwithnewarchcode branch from afba17f to 2978be0 Compare May 6, 2026 19:18

kieran-osgood-shopify merged commit 01be71e into main May 6, 2026
8 checks passed

kieran-osgood-shopify deleted the kieran-osgood/03-30-featreplaceinteropwithnewarchcode branch May 6, 2026 20:14

Juanita-Dash mentioned this pull request May 8, 2026

Import React Native package into monorepo (v4.0.0) Shopify/checkout-kit#31

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove New Arch interop checks - New Arch only#456

Remove New Arch interop checks - New Arch only#456
kieran-osgood-shopify merged 4 commits into
mainfrom
kieran-osgood/03-30-featreplaceinteropwithnewarchcode

kieran-osgood-shopify commented Mar 30, 2026 •

edited

Loading

Uh oh!

kieran-osgood-shopify commented Mar 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

kieran-osgood-shopify commented May 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kieran-osgood-shopify commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes are you making?

PR Checklist

Uh oh!

kieran-osgood-shopify commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

kieran-osgood-shopify commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kieran-osgood-shopify commented Mar 30, 2026 •

edited

Loading

kieran-osgood-shopify commented Mar 30, 2026 •

edited

Loading

github-actions Bot commented Mar 30, 2026 •

edited

Loading

kieran-osgood-shopify commented May 6, 2026 •

edited

Loading