Skip to content

Add Swift and React Native public API baselines#130

Merged
kieran-osgood-shopify merged 1 commit into
mainfrom
cx-add-swift-rn-api-baselines
May 21, 2026
Merged

Add Swift and React Native public API baselines#130
kieran-osgood-shopify merged 1 commit into
mainfrom
cx-add-swift-rn-api-baselines

Conversation

@kieran-osgood-shopify
Copy link
Copy Markdown
Contributor

@kieran-osgood-shopify kieran-osgood-shopify commented May 15, 2026

What changes are you making?

Android currently has an API dump and API check command that helps us snapshot and determine any public API drift.

this change brings the same dump and check snapshotting ability to React Native and Swift. and wires them in as blocking CI steps when we detect a public change in order to get the CIO passing, you'll need to regenerate the snapshot so that there's no drift detected on CI.

image

How to test

Example failing CI run for a branch that hadn't rebased to include mains changes of removing ec_color_scheme

https://github.com/Shopify/checkout-kit/actions/runs/25923211711/job/76197466792?pr=130


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

Web — Coverage Report

Lines Statements Branches Functions
Coverage: 98%
98.96% (571/577) 90.41% (151/167) 100% (55/55)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 95%
95.26% (181/190) 92.03% (104/113) 100% (56/56)

@kieran-osgood-shopify kieran-osgood-shopify force-pushed the cx-add-swift-rn-api-baselines branch 2 times, most recently from e8b77cc to e1b64e5 Compare May 15, 2026 14:51
@kieran-osgood-shopify kieran-osgood-shopify added the #gsd:50662 Rebase Checkout Kit on UCP label May 15, 2026
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the cx-add-swift-rn-api-baselines branch from e1b64e5 to 9465edd Compare May 21, 2026 14:33
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the cx-add-swift-rn-api-baselines branch from 9465edd to 9765026 Compare May 21, 2026 14:44
@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as ready for review May 21, 2026 15:45
@kieran-osgood-shopify kieran-osgood-shopify requested a review from a team as a code owner May 21, 2026 15:45
@kieran-osgood-shopify kieran-osgood-shopify merged commit 311e577 into main May 21, 2026
28 checks passed
Copy link
Copy Markdown
Contributor Author

Merge activity

@kieran-osgood-shopify kieran-osgood-shopify deleted the cx-add-swift-rn-api-baselines branch May 21, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants