Fix: Make Flags.from_dict generic to support all subclasses#261
Open
Mirza-Samad-Ahmed-Baig wants to merge 1 commit intoServiceNow:mainfrom
Open
Fix: Make Flags.from_dict generic to support all subclasses#261Mirza-Samad-Ahmed-Baig wants to merge 1 commit intoServiceNow:mainfrom
Mirza-Samad-Ahmed-Baig wants to merge 1 commit intoServiceNow:mainfrom
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this frog.
.--._.--.
( O O )
/ . . \
.`._______.'.
/( )\
_/ \ \ / / \_
.~ ` \ \ / / ' ~.
{ -. \ V / .- }
_ _`. \ | | | / .'_ _
>_ _} | | | {_ _<
/. - ~ ,_-' .^. `-_, ~ - .\
'-'|/ \|`-`Files scanned
| File Path | Reviewed |
|---|---|
| src/agentlab/agents/dynamic_prompting.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug in the Flags.from_dict class method where it was hardcoded to return an ObsFlags instance, preventing it from correctly instantiating other subclasses like ActionFlags. The method has been updated to be fully generic. It now uses the class it is called on (cls) for instantiation and filters the input dictionary to only include keys that correspond to the class's fields. This ensures that any subclass of Flags can be correctly created from a dictionary, making the implementation more robust and less error-prone.
Description by Korbit AI
What change is being made?
Make the
Flags.from_dictmethod generic to support all subclasses by modifying it to filter dictionary keys based on the subclass's fields and use the class itself instead of a hardcoded subclass for instantiation.Why are these changes being made?
The existing implementation of
Flags.from_dictwas not generic, as it specifically returned anObsFlagsinstance, limiting support to that subclass only. By making it generic and utilizing subclass fields dynamically, we ensure compatibility with any subclass, improving code reusability and flexibility.