-
Notifications
You must be signed in to change notification settings - Fork 227
[AgentX] vLLM Deepseek-V4 B200/B300 agg #2202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cquil11
wants to merge
11
commits into
main
Choose a base branch
from
agent/copy-pr-2188
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+255
−159
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7c5e43d
dsv4-b200-agg: DEP8 + TP8; dsv4-b300-agg: DEP4 + TP4
ivanium cbb2642
docs(agentic): set perf-changelog pr-link to #2188
ivanium 8ae6406
refactor(agentic): simplify vLLM recipe config
cquil11 db7e5a7
refactor(agentic): simplify optional variables
cquil11 9bfd6f1
Merge branch 'main' into agent/copy-pr-2188
cquil11 a14052f
Update perf-changelog.yaml
cquil11 ccf2fc3
chore(config): update DSV4 vLLM nightly
cquil11 7dfc4b8
fix(agentic): dsv4-b300 TP uses FlashInfer all-reduce, not custom
ivanium 9e51817
Require merged upstream recipe PRs (#2210)
adibarra b70303b
fix(changelog): restore stray whitespace deletions in perf-changelog
ivanium 60acff5
chore: update vllm-simple version
ivanium File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 The new B200 vllm-simple KV-offload config (line 118) hardcodes
lazy_offload:false, which per this repo's own note inkimik2.5_int4_h200.sh:47-49is known to hit apopleft_nAssertionError at low/mid CONC specifically for DSv4 + SimpleCPUOffloadConnector — exactly the combo and CONC range (8-72) swept here. It also uses keycpu_bytes_to_use_per_rankinstead of the connector's documentedcpu_bytes_to_usekey used everywhere else (kimik2.5 and the B300 sibling in this same PR), which likely means the intended CPU_BYTES_PER_RANK budget is silently ignored. Both affect every B200 vllm-simple tier innvidia-master.yaml.Extended reasoning...
Issue 1 —
lazy_offload:false(high confidence, blocking):dsv4_fp4_b200_vllm.sh:118setskv_connector_extra_config.lazy_offload=false(eager mode) forSimpleCPUOffloadConnectoron DeepSeek-V4. The repo's own documented knowledge inkimik2.5_int4_h200.sh:47-49states plainly: "JSON form (rather than--kv_offloading_backendnative shortcut) so we can passlazy_offload=true. Eager mode hits apopleft_nAssertionError at low/mid CONC on DSv4 + SimpleCPUOffloadConnector." That note is model-specific (DSv4) and connector-specific (SimpleCPUOffloadConnector) — exactly the combination this PR newly wires up for the first time on B200.nvidia-master.yamlsweeps this backend atconc-list: [8, 12, 16](pure-TP8 tier) andconc-list: [8, 16, 24, 32, 40, 48, 56, 64, 68, 72](DEP8 tier) — squarely the low/mid CONC range where the assertion was documented. Corroborating that this is an oversight rather than a deliberate change: the B300 sibling script added in this same PR wires up the identical connector but omitslazy_offloadentirely (taking the connector's default), so B200's explicitfalseis inconsistent with both its own sibling and the pre-existing, proven-safe kimik2.5 pattern. There's no evidence in the PR that the new nightly image (vllm/vllm-openai:nightly-dev-x86_64-cu13.0.1-515d6e9) fixes this path — the kimik2.5 script, unaffected by this PR, still passeslazy_offload=trueto work around it. If the assertion still fires, every B200 vllm-simple server launch crashes at startup/low-CONC.Issue 2 —
cpu_bytes_to_use_per_rankkey (lower confidence, flagged for author confirmation):The same line uses key
cpu_bytes_to_use_per_rank, whereas every other use of this connector in the repo —kimik2.5_int4_h200.sh:51and the B300 sibling added in this same PR (dsv4_fp4_b300_vllm.sh:104) — usescpu_bytes_to_use. A verifier refuted this as a bug, arguing the two keys could be deliberately different because B200's pure-TP8 vllm-simple tier is a single engine withworld_size=TP=8, and per the documented connector behavior (kimik2.5_int4_h200.sh:42-45: "SimpleCPUOffloadConnector internally dividescpu_bytes_to_useby world_size"), passing the already-dividedCPU_BYTES_PER_RANKunder the auto-dividingcpu_bytes_to_usekey would yieldTOTAL/64instead ofTOTAL/8— a real problem the author may have been trying to avoid by using a different, non-dividing key name.That concern about double-division is legitimate for the pure-TP8 tier, but it doesn't establish that
cpu_bytes_to_use_per_rankis an actual recognized connector option — no reference to it exists anywhere else in this repo, and the connector's documented interface (per kimik2.5's own comment) only knows aboutcpu_bytes_to_use. The correct fix for the pure-TP8 case, following the established kimik2.5 pattern, would have been to pass the un-divided aggregateTOTAL_CPU_DRAM_GBundercpu_bytes_to_use(letting the connector's internal division byworld_size=8produce the right per-rank share), not to invent a new key name. Separately, this same code path is also used for the B200 DEP8 tier, whereDP_ATTENTION=truemakes each engine's attentionworld_size=1(since--tensor-parallel-size 1 --data-parallel-size 8) — there, passing the pre-divided value under the realcpu_bytes_to_usekey (matching B300's DEP4 pattern) would be correct with no double-division risk at all. Sincekv_connector_extra_configis a permissive dict typically consumed via.get(key, default), the most likely outcome of the unrecognized key is that the connector silently falls back to its default CPU budget rather than the intendedTOTAL_CPU_DRAM_GB-derived budget, for both B200 vllm-simple tiers.Given the refutation raises a plausible alternative explanation that can't be fully ruled out without inspecting the pinned nightly vLLM build's actual connector source, I'm including this as a secondary, lower-confidence item for the author to confirm/fix alongside the
lazy_offloadissue — which is the well-documented, high-confidence part of this finding and is sufficient on its own to block the B200 vllm-simple tiers.Proof sketch for
lazy_offload: (1) DSv4 B200 vllm-simple tier starts withKV_OFFLOAD_BACKEND=vllm-simple,CONC=8(lowest swept value). (2) Server launches with--kv-transfer-config '{"kv_connector":"SimpleCPUOffloadConnector",...,"lazy_offload":false,...}'. (3) Per the repo's documented DSv4 + SimpleCPUOffloadConnector behavior, eager mode hits apopleft_nAssertionError at low/mid CONC. (4) The server process crashes during warmup/serving at low CONC, failing that sweep tier — exactly the failure mode kimik2.5 explicitly engineers around by settinglazy_offload=true.