-
Notifications
You must be signed in to change notification settings - Fork 179
kimik2.5-fp4-gb200-dynamo-vllm: bump vLLM image to v0.21.0 #1582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | |||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -8270,7 +8270,7 @@ kimik2.5-fp4-gb200-dynamo-trt: | ||||||||||||||||
| dp-attn: true | |||||||||||||||||
|
|
|||||||||||||||||
| kimik2.5-fp4-gb200-dynamo-vllm: | |||||||||||||||||
| image: vllm/vllm-openai:v0.18.0-cu130 | |||||||||||||||||
| image: vllm/vllm-openai:v0.21.0 | |||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 The bumped image Extended reasoning...What the bug isThe diff bumps Convention evidence in this fileEvery other gb200/gb300 vllm entry in
Conversely, every bare Proof the correct tag exists upstreamThe repository already pins the exact correct tag for gb200: Why the PR description's justification doesn't applyThe PR description says it "matches the v0.21.0 tag convention from PR #1461 ( Step-by-step proof of failure
FixChange line 8273 from: image: vllm/vllm-openai:v0.21.0to: image: vllm/vllm-openai:v0.21.0-ubuntu2404This matches the established gb200 convention in |
|||||||||||||||||
| model: nvidia/Kimi-K2.5-NVFP4 | |||||||||||||||||
| model-prefix: kimik2.5 | |||||||||||||||||
| runner: gb200 | |||||||||||||||||
|
|
|||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing
-ubuntu2404suffix for GB200 vLLM image tagHigh Severity
The image tag
vllm/vllm-openai:v0.21.0lacks the-ubuntu2404suffix required for GB200 runners. All other GB200 dynamo-vllm configs in this file (dsv4-fp4-gb200-dynamo-vllm,dsv4-fp4-gb200-dynamo-vllm-mtp2,dsv4-fp4-gb300-dynamo-vllm) use the-ubuntu2404variant which provides CUDA 13.0 and aarch64 support needed by Grace Blackwell hardware. The old image correctly used-cu130. Thev0.21.0-ubuntu2404tag exists and is the appropriate image for this runner.Reviewed by Cursor Bugbot for commit 424a294. Configure here.