Fix Agentic cross-hardware engine selection#579
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f8cb82f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Verification
pnpm --filter @semianalysisai/inferencex-app test:unit -- src/lib/exclusion.test.ts src/components/inference/utils/comparison-exclusion.test.ts(2,610 tests passed)pnpm --filter @semianalysisai/inferencex-app exec cypress run --component --spec cypress/component/scatter-graph.cy.tsx(16 tests passed)pnpm typecheckoxfmt --checkNote
Medium Risk
Changes core legend/GPU selection and comparability logic for Agentic charts; mistakes could show incomparable engines together or block valid comparisons, but behavior is heavily unit- and component-tested.
Overview
Agentic Traces STP engine rules no longer treat different GPUs as one global engine pick. Exclusion specs gain optional
scope: 'hardware'and compiled rules exposescopesOf, so cross-engine STP is blocked only on the same SKU (e.g. B200 SGLang vs B200 vLLM) while mixes like B200 SGLang and MI355X vLLM can stay on one chart. Global MTP cross-engine limits are unchanged.The exclusion resolver (
pickStickyGroup, toggles, legend universe) resolves conflicts per scope, correlates global MTP with hardware STP when picking a sticky engine, and reportspartialfamilies when one engine remains on another GPU.effectiveLegendItemsaccepts a remembered multi-GPU selection so solo/restore-all does not drop idle SKUs or forget each hardware’s engine.InferenceContext passes
scopesOffor official/overlay keys, keepspreferredHwTypesReffor legend toggles, and surfaces conflict toasts when resolution is partial. Toast copy distinguishes partial vs whole-family drops.Tests cover resolver behavior, comparison-exclusion matrix, toast messaging, and Cypress scatter/table scenarios aligned with hardware-scoped STP.
Reviewed by Cursor Bugbot for commit 2dbeb4a. Bugbot is set up for automated code reviews on this repo. Configure here.