Skip to content

feat(compare-per-dollar): embed SemiAnalysis logo in chart PNG footer #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Oseltamivir wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(compare-per-dollar): embed SemiAnalysis logo in chart PNG footer #403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions packages/app/src/app/compare-per-dollar/[slug]/performance-per-dollar.png/route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
import { readFile } from 'node:fs/promises';
import { join } from 'node:path';

import { ImageResponse } from 'next/og';

import { HW_REGISTRY } from '@semianalysisai/inferencex-constants';
Expand Down Expand Up @@ -91,6 +94,16 @@ function pointsPath(points: Point[]): string {
return points.map((point, index) => `${index === 0 ? 'M' : 'L'} ${point.x} ${point.y}`).join(' ');
}

let logoSrcPromise: Promise<string | null> | undefined;
function getLogoSrc(): Promise<string | null> {
if (!logoSrcPromise) {
logoSrcPromise = readFile(join(process.cwd(), 'public/brand/logo-color.png'))
.then((buf) => `data:image/png;base64,${buf.toString('base64')}`)
.catch(() => null);
}
return logoSrcPromise;
}
Copy link
Copy Markdown

@cursor cursor Bot May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated getLogoSrc helper across multiple files

Low Severity

The getLogoSrc function (with its module-level logoSrcPromise cache) is now copy-pasted identically in four files: this new route, compare-per-dollar/[slug]/opengraph-image.tsx, compare/[slug]/opengraph-image.tsx, and blog/[slug]/og-image-render.tsx. Extracting it into a shared utility (e.g., in @/lib) would reduce the maintenance burden and ensure any future changes (like switching the logo path) are applied consistently.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d097331. Configure here.


export async function GET(
_request: Request,
{ params }: { params: Promise<{ slug: string }> },
Expand All @@ -101,7 +114,10 @@ export async function GET(
return new Response('Not found', { status: 404 });
}

const rows = await getCachedBenchmarks(parsed.model.dbKeys);
const [rows, logoSrc] = await Promise.all([
getCachedBenchmarks(parsed.model.dbKeys),
getLogoSrc(),
]);
const { sequence, precision } = pickPairDefaults(rows, parsed.a, parsed.b);
const { ssrRows, interactivityRange } = computeCompareTableData(
rows,
Expand Down Expand Up @@ -502,6 +518,7 @@ export async function GET(
style={{
display: 'flex',
justifyContent: 'space-between',
alignItems: 'flex-end',
paddingTop: 9 * R,
fontSize: 15 * R,
color: COLORS.muted,
Expand All @@ -510,9 +527,19 @@ export async function GET(
<span style={{ display: 'flex' }}>
Owning-hyperscaler TCO | interpolated from benchmark results
</span>
<span style={{ display: 'flex', color: COLORS.text, fontWeight: 700 }}>
inferencex.semianalysis.com
</span>
<div
style={{
display: 'flex',
flexDirection: 'column',
alignItems: 'flex-end',
gap: 6 * R,
}}
>
{logoSrc && <img src={logoSrc} height={28 * R} alt="" />}
<span style={{ display: 'flex', color: COLORS.text, fontWeight: 700 }}>
inferencex.semianalysis.com
</span>
</div>
</div>
</div>,
{
Expand Down