feat(feedback): daily, immediate, center-of-page popup#402
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
UX and nudge-timing changes only; feedback API and submission paths are unchanged, with Cypress isolation added for e2e stability.
Overview
The dashboard feedback nudge now shows immediately on load (no second-visit event), uses a 24-hour snooze instead of ~90 days, and renders as a centered modal with backdrop via new
centeredmodal content andModalRendererchanges (aria-modal, backdrop dismiss).Copy drops the “You're a regular!” line in the form and registry. Visit tracking still records visits but no longer dispatches
inferencex:feedback-eligible; related constants andVisitTrackerwiring are removed.Cypress enables
supportFile: cypress/support/e2e.ts, which pre-setsinferencex-feedback-modal-snoozedbefore each visit so e2e tests aren’t blocked by the modal (specs can clear it to test the flow).Reviewed by Cursor Bugbot for commit 62d6305. Bugbot is set up for automated code reviews on this repo. Configure here.