-
Notifications
You must be signed in to change notification settings - Fork 1
Add layered plugin/skill validation tooling across agent ecosystems #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+3,282
−208
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
30e04b3
test: validate plugin manifests against vendored Cursor schemas
1e6eb84
test: validate installer-rendered plugin bundles
be81e15
test: add Cursor and Claude Code skill lint suites
0e64565
test: enforce cross-bundle plugin sync manifest
09903f9
ci: add plugin validation workflow and MCP smoke script
9de7f39
docs: document the plugin validation layers
615196a
test: integrate plugin validation checks into agent suite
f5ddb33
test: drop pass-through wrappers left by suite consolidation
563f977
ci: run plugin smoke on mcp source changes
fcfca7c
test(agent): stabilize plugin validation CI
be1570a
fix: canonicalize profile data dir roots
30016ec
test: align daemon paths with canonical profile roots
5338605
test: canonicalize storage suite profile roots
00961eb
test(storage): normalize profile shard path assertions
e1ecdda
test(plugin): remove duplicated file listing helper
fbfd9ec
Merge remote-tracking branch 'origin/master' into codex/plugin-valida…
ScriptedAlchemy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| # Schema/lint layer for the shipped agent plugin bundles. Mirrors the official | ||
| # Cursor marketplace validation workflow: | ||
| # https://github.com/cursor/plugins/blob/main/.github/workflows/validate-plugins.yml | ||
| # (ajv + ajv-formats against the plugin/marketplace JSON schemas; the schemas | ||
| # are vendored in tests/fixtures/cursor-schemas/). | ||
| # | ||
| # The Rust contract tests for the bundles already run in ci.yml — do not add | ||
| # plain cargo test jobs here. The MCP conformance smoke below is the one | ||
| # exception: it needs a built binary plus npx, which cargo test can't provide. | ||
| name: Plugin Validation | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - "cursor-plugin/**" | ||
| - "codex-plugin/**" | ||
| - "tests/fixtures/cursor-schemas/**" | ||
| # Plugin/skill test modules (e.g. plugin_manifest_schema_test.rs, | ||
| # plugin_skill_contract_test.rs, the skill lint tests). | ||
| - "tests/agent_suite/*plugin*" | ||
| - "tests/agent_suite/*skill*" | ||
| - "scripts/mcp-conformance-smoke.sh" | ||
| # The Inspector smoke is the workflow's SDK-backed coverage for | ||
| # `tracedecay serve` protocol and tool-schema compatibility. | ||
| - "src/serve.rs" | ||
| - "src/main.rs" | ||
| - "src/lib.rs" | ||
| - "src/mcp/**" | ||
| - "Cargo.toml" | ||
| - "Cargo.lock" | ||
| - ".github/workflows/plugin-validation.yml" | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| manifest-schema: | ||
| name: Manifest schema | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| steps: | ||
| - uses: actions/checkout@v7 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
|
|
||
| # Pinned, unlike upstream's floating `npm install ajv ajv-formats`. | ||
| - name: Install ajv-cli | ||
| run: npm install --no-save ajv-cli@5.0.0 ajv-formats@2.1.1 | ||
|
|
||
| - name: Compile vendored schemas | ||
| run: | | ||
| npx --no-install ajv compile --spec=draft7 -c ajv-formats \ | ||
| -s tests/fixtures/cursor-schemas/plugin.schema.json \ | ||
| -s tests/fixtures/cursor-schemas/marketplace.schema.json \ | ||
| -s tests/fixtures/cursor-schemas/mcp.schema.json \ | ||
| -s tests/fixtures/cursor-schemas/hooks.schema.json | ||
|
|
||
| - name: Validate Cursor plugin manifest | ||
| run: | | ||
| npx --no-install ajv validate --spec=draft7 -c ajv-formats --errors=text \ | ||
| -s tests/fixtures/cursor-schemas/plugin.schema.json \ | ||
| -d cursor-plugin/.cursor-plugin/plugin.json | ||
|
|
||
| # The Codex manifest follows Codex's own layout (e.g. its `interface` | ||
| # block), so the Cursor schema does not apply; keep it to a strict JSON | ||
| # well-formedness check alongside the other bundle JSON files. | ||
| - name: Check bundle JSON files parse | ||
| run: | | ||
| set -euo pipefail | ||
| find cursor-plugin codex-plugin -name '*.json' -print0 | | ||
| while IFS= read -r -d '' f; do | ||
| python3 -c "import json,sys; json.load(open(sys.argv[1]))" "$f" \ | ||
| || { echo "invalid JSON: $f" >&2; exit 1; } | ||
| echo "ok: $f" | ||
| done | ||
|
|
||
| # Drives a real `tracedecay serve` stdio server through the MCP Inspector | ||
| # CLI (pinned version), which embeds the official TypeScript MCP SDK client | ||
| # — covering protocol-version negotiation and SDK-side schema validation | ||
| # that the in-repo Rust MCP tests cannot. See scripts/mcp-conformance-smoke.sh. | ||
| mcp-conformance-smoke: | ||
| name: MCP conformance smoke | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 20 | ||
| steps: | ||
| - uses: actions/checkout@v7 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
|
|
||
| - uses: dtolnay/rust-toolchain@stable | ||
|
|
||
| - uses: Swatinem/rust-cache@v2 | ||
|
|
||
| - name: Build tracedecay | ||
| run: cargo build --bin tracedecay --locked | ||
|
|
||
| - name: Run MCP conformance smoke | ||
| run: scripts/mcp-conformance-smoke.sh | ||
| env: | ||
| TRACEDECAY_BIN: target/debug/tracedecay | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.