fix: drop non-existent services field from HealthResponse#89
Merged
FrancescoSaverioZuppichini merged 2 commits intomainfrom Apr 21, 2026
Merged
fix: drop non-existent services field from HealthResponse#89FrancescoSaverioZuppichini merged 2 commits intomainfrom
FrancescoSaverioZuppichini merged 2 commits intomainfrom
Conversation
/health returns only { status, uptime }. The HealthServices subtype
(redis/db status) was never returned by the API. Removed both the
field and the HealthServices class.
Verified against live endpoint:
curl https://v2-api.scrapegraphai.com/api/health
-> {"status": "ok", "uptime": 17936}
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Server only ever emits one of these two values (ok when redis+db are both reachable, degraded when either ping fails). Reference: apps/api/src/routes/health/index.ts:21 in sgai-api-v2-clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/healthendpoint only returns{ status, uptime }. The SDK'sHealthResponseclaimed a thirdservices: HealthServices | Nonefield (withredis+dbstatus) that the API never returns.Verified against live endpoint
Changes
HealthResponsedrops theservicesfieldHealthServicesclass deleted (dead code after the field removal)Breaking change?
Technically yes — but the field was always
Nonein practice since the API never populated it. Any code accessingres.data.serviceswas always gettingNoneor a type error. Safe to ship in a patch/minor.Test plan
uv run ruff format src testscleanuv run ruff check src testscleanuv buildsucceeds🤖 Generated with Claude Code