fix: align SDK types with actual API responses#7
Merged
VinciGit00 merged 2 commits intomainfrom Feb 17, 2026
Merged
Conversation
Verified all types against live API responses via curl. Key fixes: - ScrapeResponse: request_id → scrape_request_id, added metadata field - SearchScraperResponse: added markdown_content, num_results fields - SmartScraperParams: added mock, steps, wait_ms, country_code - SearchScraperParams: added time_range, location_geo_code, mock - MarkdownifyParams: added mock, wait_ms, country_code - CrawlParams: added breadth, batch_size, headers, wait_ms, cache_website, same_domain_only, number_of_scrolls, website_html - SitemapParams: added headers, mock, stealth - ScrapeParams: added wait_ms - AgenticScraperParams: steps is now required - Updated test mocks to match real API response shapes - Updated README with all new parameters - Added integration_test.ts for live API validation - Scoped bun test to tests/ directory Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
VinciGit00
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request_id→scrape_request_id, addedmetadatafieldmarkdown_content,num_resultsfieldsmock,steps,wait_ms,country_codetime_range,location_geo_code,mockmock,wait_ms,country_codebreadth,batch_size,headers,wait_ms,cache_website,same_domain_only,number_of_scrolls,website_htmlheaders,mock,stealthwait_msstepsis now required (matches API docs)integration_test.tsfor live API validation (bun run test:integration)bun testtotests/dir so integration test doesn't auto-runTest plan
tsc --noEmitpassesbiome check .passes🤖 Generated with Claude Code