fix: lazy imports to prevent torchcodec FFmpeg DLL crash on Windows#1092
Merged
Conversation
…1089) Remove BaseLoader inheritance from ChromiumLoader and use lazy imports for PyPDFLoader and AsyncChromiumLoader to avoid triggering the sentence_transformers -> torchcodec -> FFmpeg native DLL loading chain at import time, which crashes on systems where FFmpeg DLLs are not available. Also add torchcodec mock to conftest.py for the test suite. Changes: - chromium.py: remove BaseLoader import/inheritance, add load()/aload() - docloaders/__init__.py: lazy __getattr__ for ChromiumLoader, PlasmateLoader - fetch_node.py: lazy PyPDFLoader import - robots_node.py: lazy AsyncChromiumLoader import - conftest.py: torchcodec module mock
dosubot
Bot
added
size:M
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
|
🎉 This PR is included in version 2.1.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #1089 (merged into
pre/beta) tomain.Description
On Windows systems without FFmpeg native DLLs, importing
BaseLoaderfromlangchain_community.document_loaders.basetriggers thesentence_transformers→torchcodec→ FFmpeg loading chain, which crashes with a DLL load error.This PR fixes it via lazy imports:
BaseLoaderinheritance fromChromiumLoader(reimplementsload()/aload())__getattr__indocloaders/__init__.pyforChromiumLoader/PlasmateLoaderPyPDFLoaderandAsyncChromiumLoaderimports into function bodiestorchcodecintests/conftest.pyto prevent the crash during test importNotes
pre/beta; this brings only this fix tomain(no other beta changes).🤖 Generated with Claude Code