Fix Arctis Nova 7 battery level misreporting.#507
Open
ashirkov-c-arlo wants to merge 1 commit intoSapd:masterfrom
Open
Fix Arctis Nova 7 battery level misreporting.#507ashirkov-c-arlo wants to merge 1 commit intoSapd:masterfrom
ashirkov-c-arlo wants to merge 1 commit intoSapd:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made
Fixes battery level misreporting on SteelSeries Arctis Nova 7 headsets by replacing heuristic-based battery protocol detection with deterministic product-ID-based detection.
The Arctis Nova 7 family has two battery reporting protocols:
Original/discrete: reports battery as levels 0–4, mapped to 0%/25%/50%/75%/100%
Gen 2/percentage: reports battery as a direct 0–100 percentage
Previously, the code guessed which protocol to use at runtime by inspecting the raw battery data bytes (status byte value, battery value > 4). This heuristic had a known edge case: Gen 2 devices at 1–4% battery while charging would be misdetected as discrete-protocol devices, inflating the reported level (e.g. 2% shown as 50%).
Three files changed:
Checklist