Skip to content

Fix: Use categorization config in cicd bot environment summary #5622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
themisvaltinos merged 1 commit into from
Dec 9, 2025
Merged

Fix: Use categorization config in cicd bot environment summary #5622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions sqlmesh/integrations/github/cicd/controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,10 +448,9 @@ def prod_plan_with_gaps(self) -> Plan:
c.PROD,
# this is required to highlight any data gaps between this PR environment and prod (since PR environments may only contain a subset of data)
no_gaps=False,
# this works because the snapshots were already categorized when applying self.pr_plan so there are no uncategorized local snapshots to trigger a plan error
no_auto_categorization=True,
skip_tests=True,
skip_linter=True,
categorizer_config=self.bot_config.auto_categorize_changes,
run=self.bot_config.run_on_deploy_to_prod,
forward_only=self.forward_only_plan,
)
Expand Down
3 changes: 2 additions & 1 deletion tests/integrations/github/cicd/test_github_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,8 @@ def test_prod_plan_with_gaps(github_client, make_controller):

assert controller.prod_plan_with_gaps.environment.name == c.PROD
assert not controller.prod_plan_with_gaps.skip_backfill
assert not controller._prod_plan_with_gaps_builder._auto_categorization_enabled
# auto_categorization should now be enabled to prevent uncategorized snapshot errors
assert controller._prod_plan_with_gaps_builder._auto_categorization_enabled
assert not controller.prod_plan_with_gaps.no_gaps
assert not controller._context.apply.called
assert controller._context._run_plan_tests.call_args == call(skip_tests=True)
Expand Down
Loading