Master by twisti-dev · Pull Request #2 · SLNE-Development/surf-stats

twisti-dev · 2026-02-18T14:44:37Z

No description provided.

surf-stats plugin implementation

Added the GNU General Public License version 3 to the project.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d37a06d3e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-18T14:50:57Z

surf-stats-core/src/main/kotlin/dev/slne/surf/stats/core/database/StatsDatabaseService.kt

+            PlayersTable.upsert {
+                it[uuid] = playerUuid
+                it[name] = playerName
+                it[updatedAt] = CurrentTimestamp


Set dataVersion in custom-stat player upsert

saveCustomStats inserts/updates players without assigning dataVersion, but PlayersTable declares dataversion as a required column with no default (PlayersTable.dataVersion). When a plugin writes custom stats for a player who is not already in players, the upsert path will try to insert a row missing dataversion, causing the write to fail instead of persisting the custom stats.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-02-18T14:50:58Z

surf-stats-paper/src/main/kotlin/dev/slne/surf/stats/paper/listener/ServerShutdownListener.kt

+
+        // Cancel shared scope to kill any in-flight async coroutines (quit/world-save)
+        // before performing the synchronous shutdown save
+        pluginScope.cancel("Plugin disabling")


Avoid canceling delayed quit saves before shutdown flush

Canceling pluginScope at the start of shutdown can drop valid player saves: PlayerStatsListener schedules quit processing with a 1s delay, so a player disconnecting right before disable has an in-flight coroutine that gets canceled here, and that player is then absent from onlinePlayers for the synchronous shutdown save. In that timing window, the latest stats are never persisted.

Useful? React with 👍 / 👎.

Copilot

Pull request overview

This PR represents a complete architectural rewrite of the surf-stats plugin, migrating from a Java/Spring/Feign HTTP-based system to a Kotlin/Coroutines/R2DBC direct database implementation. The changes transform the plugin from a Bukkit implementation to a Paper-specific plugin with modern async processing.

Changes:

Complete migration from Java to Kotlin with coroutines for async operations
Replacement of Spring/Feign HTTP client architecture with direct R2DBC database access
New modular structure: surf-stats-api (interfaces) → surf-stats-core (implementation) → surf-stats-paper (Paper plugin)
Added comprehensive test coverage for core functionality
Removed old surf-stats-bukkit module, replaced with surf-stats-paper module

Reviewed changes

Copilot reviewed 78 out of 130 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
surf-stats-paper/src/main/resources/database.yml	Database configuration with connection pooling settings
surf-stats-paper/src/main/resources/config.yml	Server identification configuration
surf-stats-paper/src/main/kotlin/.../SurfStatsPlugin.kt	Main plugin lifecycle with service initialization
surf-stats-paper/src/main/kotlin/.../listener/*	Event listeners for player quit, world save, and shutdown
surf-stats-core/src/main/kotlin/.../service/StatsFileServiceImpl.kt	JSON stats file parsing implementation
surf-stats-core/src/main/kotlin/.../database/*	R2DBC database tables and persistence layer
surf-stats-core/src/test/kotlin/*	Comprehensive unit tests for core functionality
surf-stats-api/src/main/kotlin/*	Public API interfaces and data models
gradle/wrapper/gradle-wrapper.properties	Gradle wrapper configuration
README.md	Comprehensive documentation of architecture and usage

Files not reviewed (37)

.idea/.gitignore: Language not supported
.idea/compiler.xml: Language not supported
.idea/discord.xml: Language not supported
.idea/gradle.xml: Language not supported
.idea/inspectionProfiles/Project_Default.xml: Language not supported
.idea/intellij-javadocs-4.0.1.xml: Language not supported
.idea/jarRepositories.xml: Language not supported
.idea/jpa-buddy.xml: Language not supported
.idea/jpa.xml: Language not supported
.idea/jsLibraryMappings.xml: Language not supported
.idea/kotlinc.xml: Language not supported
.idea/material_theme_project_new.xml: Language not supported
.idea/misc.xml: Language not supported
.idea/modules.xml: Language not supported
.idea/modules/surf-stats-api/IdeaProjects.surf-stats.surf-stats-api.main.iml: Language not supported
.idea/modules/surf-stats-api/IdeaProjects.surf-stats.surf-stats-api.test.iml: Language not supported
.idea/modules/surf-stats-api/surf-stats-api.surf-stats.surf-stats-api.main.iml: Language not supported
.idea/modules/surf-stats-api/surf-stats-api.surf-stats.surf-stats-api.test.iml: Language not supported
.idea/modules/surf-stats-api/surf-stats.surf-stats-api.main.iml: Language not supported
.idea/modules/surf-stats-api/surf-stats.surf-stats-api.test.iml: Language not supported
.idea/modules/surf-stats-bukkit/IdeaProjects.surf-stats.surf-stats-bukkit.main.iml: Language not supported
.idea/modules/surf-stats-bukkit/IdeaProjects.surf-stats.surf-stats-bukkit.test.iml: Language not supported
.idea/modules/surf-stats-bukkit/surf-stats-bukkit.surf-stats.surf-stats-bukkit.main.iml: Language not supported
.idea/modules/surf-stats-bukkit/surf-stats-bukkit.surf-stats.surf-stats-bukkit.test.iml: Language not supported
.idea/modules/surf-stats-bukkit/surf-stats.surf-stats-bukkit.iml: Language not supported
.idea/modules/surf-stats-bukkit/surf-stats.surf-stats-bukkit.main.iml: Language not supported
.idea/modules/surf-stats-bukkit/surf-stats.surf-stats-bukkit.test.iml: Language not supported
.idea/modules/surf-stats-core/IdeaProjects.surf-stats.surf-stats-core.main.iml: Language not supported
.idea/modules/surf-stats-core/IdeaProjects.surf-stats.surf-stats-core.test.iml: Language not supported
.idea/modules/surf-stats-core/surf-stats-core.surf-stats.surf-stats-core.main.iml: Language not supported
.idea/modules/surf-stats-core/surf-stats-core.surf-stats.surf-stats-core.test.iml: Language not supported
.idea/modules/surf-stats-core/surf-stats.surf-stats-core.main.iml: Language not supported
.idea/modules/surf-stats-core/surf-stats.surf-stats-core.test.iml: Language not supported
.idea/prettier.xml: Language not supported
.idea/surf-stats.iml: Language not supported
.idea/uiDesigner.xml: Language not supported
.idea/vcs.xml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-18T14:58:08Z

surf-stats-paper/src/main/kotlin/dev/slne/surf/stats/paper/listener/WorldSaveListener.kt

+    // arrive in quick succession. We debounce by cancelling any pending job on each event,
+    // ensuring we only process stats once per save cycle. The 5s delay also gives Minecraft
+    // time to finish flushing all stats files to disk.
+    private var saveJob: Job? = null


The saveJob field is accessed from multiple threads (event handler thread and coroutine context) without synchronization. While Job operations are thread-safe, consider using @volatile annotation or AtomicReference to make the intent explicit and ensure proper memory visibility across threads.

Copilot · 2026-02-18T14:58:08Z

gradle/wrapper/gradle-wrapper.properties

-distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip
-networkTimeout=10000
-validateDistributionUrl=true
+distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.0-milestone-1-all.zip


The Gradle wrapper is configured to use a milestone (pre-release) version "9.5.0-milestone-1". Milestone versions are not stable releases and may contain bugs or breaking changes. Consider using a stable Gradle release version for production code to ensure reliability and compatibility.

Copilot · 2026-02-18T14:58:09Z

surf-stats-paper/src/main/resources/database.yml

+  username: my_user
+  password: my_password


Hardcoded database credentials in a version-controlled configuration file pose a security risk. Consider using environment variables or a secure credential management system instead of committing actual credentials to the repository.

Copilot · 2026-02-18T14:58:09Z

surf-stats-paper/src/main/kotlin/dev/slne/surf/stats/paper/SurfStatsPlugin.kt

+        runBlocking {
+            fileService.initialize(statsDirectory)
+        }
+
+        // Initialize database
+        saveResource("database.yml", false)
+        databaseApi = DatabaseApi.create(pluginPath = dataFolder.toPath())
+        val databaseService = StatsDatabaseService(serverName, serverLabel)
+        runBlocking {
+            databaseService.registerServer()
+        }


The runBlocking calls in the onEnable lifecycle block the main server thread during plugin initialization. Consider using a launch with appropriate error handling instead, or document why blocking is necessary here. Blocking the main thread during server startup could cause performance issues.

Copilot · 2026-02-18T14:58:09Z

surf-stats-paper/src/main/kotlin/dev/slne/surf/stats/paper/listener/ServerShutdownListener.kt

+
+    @EventHandler(priority = EventPriority.MONITOR)
+    fun onPluginDisable(event: PluginDisableEvent) {
+        if (event.plugin.name != "surf-stats-paper") return


The plugin name check uses a hardcoded string "surf-stats-paper" which could break if the plugin name changes. Consider using event.plugin == this@SurfStatsPlugin or storing the plugin reference to compare directly, making the code more robust to refactoring.

TheBjoRedCraft · 2026-02-18T14:49:11Z

gradle/libs.versions.toml

+surf-database = "1.3.0"
+kotlinx-serialization = "1.10.0"
+kotlinx-coroutines = "1.9.0"
+junit = "5.11.3"

 [libraries]
-surf-data-api = { module = "dev.slne:surf-data-api", version.ref = "surf-data-api-version" }
-surf-api = { module = "dev.slne.surf:surf-api-bukkit-api", version.ref = "surf-api-version" }
-paper-api = { module = "io.papermc.paper:paper-api", version.ref = "paper-api-version" }
-fast-util = { module = "it.unimi.dsi:fastutil", version.ref = "fast-util-version" }
-maven-settings-plugin = { module = "net.linguica.gradle:maven-settings-plugin", version.ref = "maven-settings-plugin-version" }
-shadow-plugin = { module = "com.github.johnrengelman:shadow", version.ref = "shadow-plugin-version" }
-
-[plugins]
-run-paper-plugin = { id = "xyz.jpenilla.run-paper", version = "2.2.2" }
+surf-database-r2dbc = { module = "dev.slne.surf:surf-database-r2dbc", version.ref = "surf-database" }


Suggested change

surf-database = "1.3.0"

kotlinx-serialization = "1.10.0"

kotlinx-coroutines = "1.9.0"

junit = "5.11.3"

[libraries]

surf-data-api = { module = "dev.slne:surf-data-api", version.ref = "surf-data-api-version" }

surf-api = { module = "dev.slne.surf:surf-api-bukkit-api", version.ref = "surf-api-version" }

paper-api = { module = "io.papermc.paper:paper-api", version.ref = "paper-api-version" }

fast-util = { module = "it.unimi.dsi:fastutil", version.ref = "fast-util-version" }

maven-settings-plugin = { module = "net.linguica.gradle:maven-settings-plugin", version.ref = "maven-settings-plugin-version" }

shadow-plugin = { module = "com.github.johnrengelman:shadow", version.ref = "shadow-plugin-version" }

[plugins]

run-paper-plugin = { id = "xyz.jpenilla.run-paper", version = "2.2.2" }

\ No newline at end of file

surf-database-r2dbc = { module = "dev.slne.surf:surf-database-r2dbc", version.ref = "surf-database" }

kotlinx-serialization = "1.10.0"

kotlinx-coroutines = "1.9.0"

junit = "5.11.3"

[libraries]

Kannst du direkt über surfapi machen in dem Module wo du es brauchst
https://github.com/SLNE-Development/surf-chat/blob/238a6b7ffe5a561cb373cef57fc6906550154003/surf-chat-fallback/build.gradle.kts#L6

TheBjoRedCraft · 2026-02-18T14:49:41Z

gradle/libs.versions.toml

+kotlinx-serialization-json = { module = "org.jetbrains.kotlinx:kotlinx-serialization-json", version.ref = "kotlinx-serialization" }
+kotlinx-coroutines-core = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-core", version.ref = "kotlinx-coroutines" }
+kotlinx-coroutines-test = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-test", version.ref = "kotlinx-coroutines" }


sollte alles in surf api drin sein

Suggested change

kotlinx-serialization-json = { module = "org.jetbrains.kotlinx:kotlinx-serialization-json", version.ref = "kotlinx-serialization" }

kotlinx-coroutines-core = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-core", version.ref = "kotlinx-coroutines" }

kotlinx-coroutines-test = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-test", version.ref = "kotlinx-coroutines" }

TheBjoRedCraft · 2026-02-18T14:50:00Z

gradle/libs.versions.toml

+kotlinx-serialization = "1.10.0"
+kotlinx-coroutines = "1.9.0"


Suggested change

kotlinx-serialization = "1.10.0"

kotlinx-coroutines = "1.9.0"

sollte in surf api drin sein

TheBjoRedCraft · 2026-02-18T14:51:33Z

surf-stats-api/src/main/kotlin/dev/slne/surf/stats/api/SurfStatsApi.kt

+    /**
+     * The server name used for stats attribution.
+     */
+    val serverName: String


hierfür kannst du surf core nutzen

https://docs.slne.dev/surf-core/server-management

TheBjoRedCraft · 2026-02-18T14:52:28Z

surf-stats-core/src/main/kotlin/dev/slne/surf/stats/core/database/table/PlayersTable.kt

+import dev.slne.surf.database.libs.org.jetbrains.exposed.v1.javatime.CurrentTimestamp
+import dev.slne.surf.database.libs.org.jetbrains.exposed.v1.javatime.timestamp
+
+object PlayersTable : Table("players") {


Kannst einen AuditableLongIdTable nutzen, da ist updated und createdAt direkt bei

TheBjoRedCraft · 2026-02-18T15:06:16Z

surf-stats-paper/src/main/resources/database.yml

+logLevel: DEBUG
+credentials:
+  host: localhost
+  port: 3306
+  database: my_database
+  username: my_user
+  password: my_password
+pool:
+  sizing:
+    initialSize: 10
+    minIdle: 0
+    maxSize: 10
+  timeouts:
+    maxAcquireTimeMillis: 10000
+    maxCreateConnectionTimeMillis: 30000
+    maxValidationTimeMillis: -1
+    maxIdleTimeMillis: 60000
+    maxLifeTimeMillis: 1800000


surf database nutzen

TheBjoRedCraft · 2026-02-18T15:06:25Z

surf-stats-paper/src/main/resources/config.yml

+server:
+  name: "my-server"
+  label: "My Server"


surf core nutzen, siehe oben

TheBjoRedCraft · 2026-02-18T15:06:59Z

surf-stats-paper/build.gradle.kts

+
+surfPaperPluginApi {
+    mainClass("dev.slne.surf.stats.paper.SurfStatsPlugin")
+    authors.add("SLNE Dev Team")


Suggested change

authors.add("SLNE Dev Team")

authors.add("Jan")

TheBjoRedCraft · 2026-02-18T15:07:40Z

surf-stats-paper/build.gradle.kts

+}
+
+surfPaperPluginApi {
+    mainClass("dev.slne.surf.stats.paper.SurfStatsPlugin")


Suggested change

mainClass("dev.slne.surf.stats.paper.SurfStatsPlugin")

mainClass("dev.slne.surf.stats.paper.PaperMain")

siehe oben, direkt auch echten File und Klassennamen updaten

TheBjoRedCraft · 2026-02-18T15:07:53Z

surf-stats-paper/build.gradle.kts

+tasks.processResources {
+    expand("version" to project.version)
+}


brauchen wir nicht

Co-author: red

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

janhoeck added 17 commits February 8, 2026 11:44

Init commit

a7d59f7

Start adding some implementations

e41a3f8

Implement real world stats test

1996db0

Implement database

b24ed2d

Add database.yml

fc3f513

Create server on startup

02799cd

Merge pull request #1 from SLNE-Development/dev

873a967

surf-stats plugin implementation

Update git ignore

03570b1

Remove .idea and .claude from version control

1598b9b

Fix some start up issues

a4e7581

Fix some start up issues (2)

b7e779f

Fix some start up issues (3)

591ddfb

Add save on world save

c647be4

More performance

6d82843

Fix unit test

84b77cb

Add documentation

1ae7c87

Add support for saving custom stats

1d37a06

twisti-dev assigned janhoeck Feb 18, 2026

Copilot AI review requested due to automatic review settings February 18, 2026 14:44

Copilot started reviewing on behalf of twisti-dev February 18, 2026 14:45 View session

TheBjoRedCraft requested review from TheBjoRedCraft and Copilot and removed request for TheBjoRedCraft and Copilot February 18, 2026 14:46

[ci-skip] Add GNU GPL v3 license

d659e9e

Added the GNU General Public License version 3 to the project.

chatgpt-codex-connector bot reviewed Feb 18, 2026

View reviewed changes

Copilot started reviewing on behalf of TheBjoRedCraft February 18, 2026 14:51 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

TheBjoRedCraft requested changes Feb 18, 2026

View reviewed changes

Some refactoring

0cb5aac

Co-author: red

Remove constructor

a338cb3

Copilot AI review requested due to automatic review settings February 20, 2026 18:51

Copilot AI reviewed Feb 20, 2026

View reviewed changes

janhoeck added 2 commits February 20, 2026 19:55

Fix dataversion error

32200d6

Remove logging

e86d00f

Copilot AI review requested due to automatic review settings February 21, 2026 17:44

Copilot AI reviewed Feb 21, 2026

View reviewed changes

Save players in a batch on shutdown

75e6607

Copilot AI review requested due to automatic review settings February 24, 2026 18:16

Copilot AI reviewed Feb 24, 2026

View reviewed changes

	kotlinx-serialization-json = { module = "org.jetbrains.kotlinx:kotlinx-serialization-json", version.ref = "kotlinx-serialization" }
	kotlinx-coroutines-core = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-core", version.ref = "kotlinx-coroutines" }
	kotlinx-coroutines-test = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-test", version.ref = "kotlinx-coroutines" }

		kotlinx-serialization = "1.10.0"
		kotlinx-coroutines = "1.9.0"

	mainClass("dev.slne.surf.stats.paper.SurfStatsPlugin")
	mainClass("dev.slne.surf.stats.paper.PaperMain")

Conversation

twisti-dev commented Feb 18, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants