SapMachine #2216: add Debian APT repository generation script#2271
Open
EdrilanBerisha wants to merge 3 commits into
Open
SapMachine #2216: add Debian APT repository generation script#2271EdrilanBerisha wants to merge 3 commits into
EdrilanBerisha wants to merge 3 commits into
Conversation
Fixes SAP#2216 The sapmachine apt repository at dist.sapmachine.io was non-compliant with the Debian Repository Format specification (https://wiki.debian.org/DebianRepository/Format): 1. The suite was './', which is not a real suite name. Most tools other than apt itself generate broken URLs from this. 2. The Release file at https://dist.sapmachine.io/debian/amd64//Release was missing the required 'Architecture:' field. This commit adds make/scripts/generate-debian-repo.sh: a bash script that generates a standards-compliant Debian APT repository, and make/scripts/test-generate-debian-repo.sh: 30 unit tests covering argument validation, suite name validation, Release file structure, directory layout, and checksum sections. Key fixes in the generated repository: - Suite is a proper name (e.g. 'sapmachine', 'stable') — never './' - Release file always includes Architecture: field - Release file includes all required fields: Suite, Codename, Components, Architecture, Origin, Label, Date - Repository follows the canonical dists/SUITE/COMPONENT/binary-ARCH/ layout with pool/ for the .deb packages - SHA256/SHA1/MD5Sum checksums included in Release - GPG signing support via --gpg-key option (InRelease + Release.gpg)
The sapmachine apt repository at dist.sapmachine.io was non-compliant with the Debian Repository Format specification (https://wiki.debian.org/DebianRepository/Format): 1. The suite was './', which is not a real suite name. Most tools other than apt itself generate broken URLs from this. 2. The Release file at https://dist.sapmachine.io/debian/amd64//Release was missing the required 'Architecture:' field. This commit adds make/scripts/generate-debian-repo.sh: a bash script that generates a standards-compliant Debian APT repository, and make/scripts/test-generate-debian-repo.sh: 30 unit tests covering argument validation, suite name validation, Release file structure, directory layout, and checksum sections. Key fixes in the generated repository: - Suite is a proper name (e.g. 'sapmachine', 'stable') — never './' - Release file always includes Architecture: field - Release file includes all required fields: Suite, Codename, Components, Architecture, Origin, Label, Date - Repository follows the canonical dists/SUITE/COMPONENT/binary-ARCH/ layout with pool/ for the .deb packages - SHA256/SHA1/MD5Sum checksums included in Release - GPG signing support via --gpg-key option (InRelease + Release.gpg) fixes SAP#2216
Member
|
Hello @EdrilanBerisha, this pull request fulfills all formal requirements. |
Author
|
@bzed maybe you can clone this branch and test it at least and help to verify it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sapmachine apt repository at dist.sapmachine.io was non-compliant with the Debian Repository Format specification (https://wiki.debian.org/DebianRepository/Format):
./, which is not a real suite name. Most tools other than apt itself generate broken URLs from this.Architecture:field.This commit adds
make/scripts/generate-debian-repo.sh: a bash script that generates a standards-compliant Debian APT repository, andmake/scripts/test-generate-debian-repo.sh: 30 unit tests covering argument validation, suite name validation, Release file structure, directory layout, and checksum sections.Key fixes in the generated repository:
sapmachine,stable) — never./Architecture:fielddists/SUITE/COMPONENT/binary-ARCH/layout withpool/for the .deb packages--gpg-keyoption (InRelease + Release.gpg)fixes #2216