Add method to check if a path in zipfs is a symbolic link#2219
Add method to check if a path in zipfs is a symbolic link#2219RealCLanger merged 5 commits intoSAP:sapmachinefrom
Conversation
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
|
restest this please |
|
Do you really need this SharedSecrets stuff? I think for jdk.nio.zipfs it is fine to add public methods and call them since those are internal implementation classes. You should only need to export the jdk.nio.zipfs package to jdk.sapext and then you can directly call any method you add. |
|
Regarding the shared secrets. A public method in an implementation class for which the user gets access too is still visible. Additionally I don't want to add a module dependency between the ext and the zipfs module, when it is not really needed. |
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
Sure but having this public method visible is no problem. jdk.nio.zipfs.ZipFileSystem is no public API class so nobody would see it as API. Obviously somebody might go and try to reflectively look it up and use it. But that's possible with any internal class and developers should avoid that because of compatibility risk. Also, in later JDKs reflective access is disabled by default or should be soon - not exactly sure where Java is at at the moment... 😄 If you want to avoid a dependency between jdk.sapext and jdk.zipfs the way to go would also using services. |
RealCLanger
left a comment
RealCLanger
left a comment
There was a problem hiding this comment.
OK, a few last minor suggestions...
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
4 participants
This adds a method to check if a given path from zipfs corresponds to a symbolic link.
fixes #2218