hc-256: use ptable instead of qtable in h2 function#324
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom Jun 23, 2023
cdong1012:master
Merged
hc-256: use ptable instead of qtable in h2 function#324tarcieri merged 1 commit intoRustCrypto:masterfrom cdong1012:master
ptable instead of qtable in h2 function#324tarcieri merged 1 commit intoRustCrypto:masterfrom
cdong1012:master
Conversation
Contributor
Author
|
Seems like this is duplicate with #283. Should I rebase and update this PR to cipher_v0.5? |
Member
|
Oh wow, looks like #283 went by the wayside. @cdong1012 #283 had quite a bit going on including adding an implementation of HC-128, which is what blocked merging it. I think it would be good to just split out the HC-256 fixes for starters, possibly in this PR. You already have the After that, I think HC-128 could be added in a separate PR. |
tarcieri
changed the title
ptable instead of qtable in h2 function
tarcieri
approved these changes
Jun 23, 2023
Member
|
Actually, let's go ahead and get this merged so it doesn't go by the wayside like #283 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a small bug in the HC-256 stream cipher to use ptable instead of qtable for the h2 function. The code properly decrypts up to 0x1000 bytes, but it fails to decrypt data that comes afterward due to this bug.
Data encrypted by the original code can still be fully decrypted despite its length, but will fail to be decrypted by other HC-256 libraries.