tls_codec: revert serde_bytes for VLBytes and add VLByteVec#2322
Open
kkohbrok wants to merge 3 commits intoRustCrypto:masterfrom
Open
tls_codec: revert serde_bytes for VLBytes and add VLByteVec#2322kkohbrok wants to merge 3 commits intoRustCrypto:masterfrom
kkohbrok wants to merge 3 commits intoRustCrypto:masterfrom
Conversation
boxdot
approved these changes
Apr 29, 2026
Contributor
boxdot
left a comment
boxdot
left a comment
There was a problem hiding this comment.
Thank you! This is a good change allowing to use the old building blocks and to use the new building blocks with the old data.
| feature = "serde", | ||
| serde(deserialize_with = "serde_compat::deserialize_vlbytes_compat") | ||
| )] | ||
| vec: Vec<u8>, |
Contributor
There was a problem hiding this comment.
Nice simplification with serde(transparent).
Comment on lines
+381
to
+386
| #[cfg(feature = "std")] | ||
| impl Zeroize for VLByteVec { | ||
| fn zeroize(&mut self) { | ||
| self.vec.zeroize(); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
If I am not mistaken, Zeroize should be only implemented for VLSecretByteVec, right?
Contributor
There was a problem hiding this comment.
Ah no. This just allows to zeroize the vec, but does not do it automatically on drop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VLBytesandSecretVLBytesVLByteVecandSecretVLByteVecVLBytes