avoid crash when window is null in become_first_responder#204
Merged
micahrj merged 3 commits intoRustAudio:masterfrom Apr 14, 2025
Merged
avoid crash when window is null in become_first_responder#204micahrj merged 3 commits intoRustAudio:masterfrom
micahrj merged 3 commits intoRustAudio:masterfrom
Conversation
micahrj
approved these changes
Apr 11, 2025
Member
|
It looks like the build is failing due to warnings in the Long-term I think the best thing to do would be to switch to the #![allow(unexpected_cfgs)] |
Quant1um
added a commit
to blepfx/baseview
that referenced
this pull request
Jul 20, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apparently newer Rust versions (starting with 1.86?) have stricter debug assertions regarding unsafe code which caused a crash under debug builds because
windowwas null in thebecome_first_respondermethod.this fix simply checks whether
windowis null or not.