Enable various new clippy lints#1025
Open
tgross35 wants to merge 7 commits intoRust-for-Linux:rust-nextfrom
Open
Enable various new clippy lints#1025tgross35 wants to merge 7 commits intoRust-for-Linux:rust-nextfrom
tgross35 wants to merge 7 commits intoRust-for-Linux:rust-nextfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies a most of what is discussed in #349.
Additionally, I enabled a large subset of lints from
pedanticthat shouldn't be too annoying, but should improve consistency and correctness.This patchset can be reviewed per-commit, each patch should build correctly. A few things I need feedback on:
// SAFETY: TODOcomments inrust/kernel/init. I'm not too familiar with how this portion - could somebody more familiar to fill in those blanks and generally verify the safety comments ininit