Fixed a bug where self-referential types would cause infinite recursion and stack overflows#277
Open
FractalFir wants to merge 2 commits intoRust-GPU:mainfrom
Open
Fixed a bug where self-referential types would cause infinite recursion and stack overflows#277FractalFir wants to merge 2 commits intoRust-GPU:mainfrom
FractalFir wants to merge 2 commits intoRust-GPU:mainfrom
Conversation
…sting it to check the intiger bit width
FractalFir
force-pushed
the
type_overflow_fix
branch
from
89697ec to
943152d
Compare
LegNeato
approved these changes
Sep 21, 2025
Contributor
LegNeato
left a comment
LegNeato
left a comment
There was a problem hiding this comment.
These all look fine but the PRs are overlapping?
Collaborator
Author
Yeah, must have screwed something up in git. I have a couple of completely unrelated bug-fixes(couple more on the way), so managing them all has been a challenge. Will fix tomorrow. |
Contributor
|
@FractalFir is this still relevant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title states. Currently, self-referential types would cause stack overflows(because if
Foocontains aFoo*, then that creates an unsatisfiable cycle).This PR just uses
u8*everywhere instead. Typed pointers are a relic of old LLVM, so getting rid of them(even if partially) now can only do us good.