Fix SSE client error handling and propagate API key in headers#103
Merged
Fix SSE client error handling and propagate API key in headers#103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes bugs in the SSE client related to error handling and API key propagation. The SSE client was not properly handling error scenarios, and the API key was not being passed through in request headers, causing authentication failures during server-sent event connections.
Key Accomplishments
CreateEventHandlerRequestmodel to fix a field type/definition issue.Changes Breakdown
operation_client.pysse_client.pycreate_event_handler_request.pytest_sse_client.pyBreaking Changes
None. These changes are backward-compatible fixes that improve reliability without altering the public API surface.
Testing Notes
test_sse_client.pycovering error handling paths in the SSE client.Infrastructure Considerations
🤖 Generated with Claude Code
Branch Info:
bugfix/sse-client-bugmainCo-Authored-By: Claude noreply@anthropic.com