Fix: anchor MasterCard credit-card pattern (missing ^ regressed in 94a79c033)#1774
Open
nikkoenggaliano wants to merge 1 commit into
Open
Fix: anchor MasterCard credit-card pattern (missing ^ regressed in 94a79c033)#1774nikkoenggaliano wants to merge 1 commit into
^ regressed in 94a79c033)#1774nikkoenggaliano wants to merge 1 commit into
Conversation
The `MasterCard` entry in `CreditCard`'s `BRAND_REGEX_LIST` is the only one of
the eight brand patterns missing a leading `^` anchor. Because of this,
`v::creditCard('MasterCard')` accepts inputs that are **not** valid MasterCard
numbers specifically, Luhn-valid digit strings **longer than 16 digits**
whose trailing 16 digits match the MasterCard pattern.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.1 #1774 +/- ##
=========================================
Coverage 99.41% 99.41%
Complexity 1020 1020
=========================================
Files 194 194
Lines 2387 2387
=========================================
Hits 2373 2373
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MasterCardentry inCreditCard'sBRAND_REGEX_LISTis the only one of the eight brand patterns missing a leading^anchor. Because of this,v::creditCard('MasterCard')accepts inputs that are not valid MasterCard numbers specifically, Luhn-valid digit strings longer than 16 digits whose trailing 16 digits match the MasterCard pattern.Self-contained demonstration (no Composer needed), mirroring
evaluate()+Luhn::isValid()and using the verbatim shipped regex:Fix
Regression test
Add to
providerForInvalidInput()intests/unit/Validators/CreditCardTest.php(alongside the other$masternegatives):