Skip to content

fix: map group ids to names for system filter#1632

Open
xbhouse wants to merge 2 commits into
RedHatInsights:masterfrom
xbhouse:group-ids-to-names
Open

fix: map group ids to names for system filter#1632
xbhouse wants to merge 2 commits into
RedHatInsights:masterfrom
xbhouse:group-ids-to-names

Conversation

@xbhouse
Copy link
Copy Markdown
Collaborator

@xbhouse xbhouse commented May 21, 2026

Description

Uses inventory client to resolve group ids to names to fix system filtering by workspace

How to test the PR

  • The "Verify filter contents" UI test should pass
  • Workspace filtering should work correctly in the UI and ids should not be in the query param or filter chip

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 21, 2026

Codecov Report

❌ Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.51%. Comparing base (16b8e0f) to head (28650bd).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Utilities/hooks/useHostGroupFilter.js 53.33% 3 Missing and 4 partials ⚠️
src/Utilities/api/api.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1632      +/-   ##
==========================================
- Coverage   77.58%   77.51%   -0.08%     
==========================================
  Files         103      104       +1     
  Lines        3266     3291      +25     
  Branches      733      735       +2     
==========================================
+ Hits         2534     2551      +17     
- Misses        655      659       +4     
- Partials       77       81       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@swadeley swadeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@swadeley swadeley self-assigned this May 21, 2026
@xbhouse xbhouse marked this pull request as ready for review May 21, 2026 18:14
@xbhouse xbhouse requested a review from a team as a code owner May 21, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants