fix: Make SDK compatible with PHP 8.4#773
Draft
ninjasimon wants to merge 5 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 674ffaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
elgouttefangeas
previously approved these changes
May 13, 2026
Contributor
🔍 PHP SDK Changes PreviewDiff is too large to display inline 📦 Download the rebilly-sdk-diff artifact from the workflow run for a formatted HTML diff. Updated: 2026-05-15 13:32:04 UTC |
ashkarpetin
previously approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.4 deprecates implicit-nullable parameters. The SDK's exception classes used this pattern on the
$previousconstructor parameter, which produced deprecation notices when running on PHP 8.4. This PR addsexplicit nullability in both the generated
src/Exception/classes and the localDataValidationExceptiontemplate, bumps
@rebilly/regeneratorto^0.0.9to pick up the matching fix in the bundled templates, andadds PHP 8.3 and 8.4 to the CI matrix to lock the contract in.