feat(types): canonical H2O column wrappers — top/bot/pearson_corr/std/__pow__#12
Open
ser-vasilich wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 15, 2026
raypy_kdb.c uses getaddrinfo + struct addrinfo from <netdb.h>, which glibc only exposes when _GNU_SOURCE (or _POSIX_C_SOURCE >= 200112L) is set. Without it, -std=c17 -Werror build fails on Linux with 'incomplete type struct addrinfo'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single commit on top of
rayforce2adding Column methods needed for canonical H2O groupby coverage in rayforce-bench. 56 lines across 3 files — pure Python AST additions, no C/FFI changes.New methods on
Column/AggregationMixinColumn("v3").top(n)— n largest per group, descending (canonical H2O q8)Column("v3").bot(n)— n smallest per group, ascendingColumn("v1").pearson_corr(Column("v2"))— Pearson correlation (q9, with** 2second stage)Column("v3").std()— sample stddev, ddof=1, matches polars/pandas (q6 stddev side)Column("v3") ** 2(__pow__/__rpow__)New
Operationenum entriesPOW,STDDEV,PEARSON_CORR,TOP,BOT.MEDIANandDEVIATIONalready existed (engine verbsmed/dev).Each wrapper is a 1-line
return Expression(Operation.X, self, …)— relies only on the existing Expression-AST mechanism.Engine support
Verb names match engine opcodes landing in:
top,bot,pearson_corr,powprimitives)Test plan
rayforce2make check LOCAL=1in rayforce-bench →pass — 665/665