feat: enable camera for video extenstion and microphone for recording#1493
Open
DNR500 wants to merge 1 commit into
Open
feat: enable camera for video extenstion and microphone for recording#1493DNR500 wants to merge 1 commit into
DNR500 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Scratch editor iframe configuration so that Scratch extensions requiring hardware access (camera/video sensing and microphone recording) can request permissions without triggering Permissions Policy violations.
Changes:
- Adds
allow="camera; microphone"to the Scratch iframe. - Updates the ScratchContainer test to validate the presence of the
allowattribute.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/Editor/Project/ScratchContainer.jsx | Enables camera and microphone permissions on the embedded Scratch iframe via the allow attribute. |
| src/components/Editor/Project/ScratchContainer.test.js | Adds coverage asserting the iframe exposes the expected permission configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ); | ||
| expect(viewport).toHaveClass("scratch-container__viewport"); | ||
| expect(iframe).toBeInTheDocument(); | ||
| expect(iframe).toHaveAttribute("allow", "camera; microphone"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that the video extension and the sound recording need an attribute adding on the scratch iframe.
Without this you get violations in the console for the camera - or the microphone can not connect
Simple fix here should get it working, so the user should be accessed for permission to connect liek in the following images.