Error message UI rebased to 1448#1487
Draft
cocomarine wants to merge 58 commits into
Draft
Conversation
Closed
…icitly rawTraceback contains `<exec>` instead of `main.py` as the filename, for example, we can now override the filename passed to friendlyExplain()
…iFoundation/editor-ui into 1448-and-ui-branches-combined
PFEM 0.6.0 markup has improved accessibility attributes, such as aria labels and roles. Has no effect on the styling (since classes, and the markup as a whole, remain the same).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗ This branch was created by rebasing #1485 to #1483.
Decisions made upon adding pfem v. 0.5.0
ErrorMessagenow optionally includesFriendlyErrorMessageErrorMessageto the bottom of input panel above Run buttonMobileProject), when the error is triggered after run, the input panel becomes the selected tab so that users can see the error (if no error triggered, the output panel becomes selected)WebcomponentProject.jsx, EditorInput is rendered at all in output only mode, resulting inErrorMessagedisplayed only by Output panel of Pyodidemain.pyshows first.main.py, they will show (one at a time).Screenshots
friendly_errors_enabledattribute is set to true:Pyodide
Skulpt