Skip to content

Stop swallowing errors from tasks #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zetter-rpf wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Stop swallowing errors from tasks #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4605532
Stop swallowing errors from tasks
zetter-rpf Mar 2, 2026
b315088
Only destroy the school if it exists
zetter-rpf Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions lib/tasks/for_education.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,9 @@ namespace :for_education do
SchoolClass.where(id: [school_class_ids]).destroy_all

# Destroy the school
School.find(school_id).destroy
School.where(id: school_id).destroy_all

Rails.logger.info 'Done...'
rescue StandardError => e
Rails.logger.error "Failed: #{e.message}"
raise ActiveRecord::Rollback
end
end

Expand All @@ -60,9 +57,6 @@ namespace :for_education do
create_school(creator_id, TEST_SCHOOL)

Rails.logger.info 'Done...'
rescue StandardError => e
Rails.logger.error "Failed: #{e.message}"
raise ActiveRecord::Rollback
end
end

Expand All @@ -80,9 +74,6 @@ namespace :for_education do
school = create_school(creator_id, TEST_SCHOOL)
verify_school(school)
Rails.logger.info 'Done...'
rescue StandardError => e
Rails.logger.error "Failed: #{e.message}"
raise ActiveRecord::Rollback
end
end

Expand Down Expand Up @@ -110,9 +101,6 @@ namespace :for_education do
create_project(creator_id, school, lesson)
end
Rails.logger.info 'Done...'
rescue StandardError => e
Rails.logger.error "Failed: #{e.message}"
raise ActiveRecord::Rollback
end
end
end
7 changes: 0 additions & 7 deletions lib/tasks/test_seeds.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ namespace :test_seeds do
School.where(id: school_ids).destroy_all

Rails.logger.info 'Done...'
rescue StandardError => e
pp "Failed: #{e.message}"
Rails.logger.error "Failed: #{e.message}"
raise ActiveRecord::Rollback
end
end

Expand Down Expand Up @@ -74,9 +70,6 @@ namespace :test_seeds do
end
end
Rails.logger.info 'Done...'
rescue StandardError => e
Rails.logger.error "Failed: #{e.message}"
raise ActiveRecord::Rollback
end
end
end
Expand Down