Conversation
* feat: Add dynamic keycode for primary modifier key * fix: Don't duplicate constants.
* fix: Focus the nearest neighbor on block deletion * test: Add tests * fix: Use `strictEqual` * chore: Reduce the number of test blocks * fix: Explicitly verify that dying blocks are not focused * fix: Fix exception when disposing of a workspace with a focused block * chore: Run formatter
* feat: Add support for getting the contextual menu * feat: Add a keyboard shortcut for opening the contextual menu * test: Add tests for `ContextMenu.getMenu()`. * test: Add tests for context menu keyboard shortcut * fix: Fix tests when not run on their own * chore: Add type annotation
Contributor
|
"No supported platform for closure compiler found" is haunting me. I thought I fixed this here #9575 (comment) any ideas? |
Contributor
Author
|
I think it just needs updating again? Unclear why v13 is different, but I've had that failure on all PRs against 13 and updating it resolves it. I can send another PR doing that after this one is merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
This PR merges the latest changes from
maininto thev13branch. This includes the CTRL_CMD keycode we need for the move mode PR.This should be a MERGE COMMIT.