Skip to content

Fr 00002 cache cli with config flag#4

Merged
RandomGenericUsername merged 3 commits intomasterfrom
FR-00002__cache-cli-with-config-flag
Mar 24, 2026
Merged

Fr 00002 cache cli with config flag#4
RandomGenericUsername merged 3 commits intomasterfrom
FR-00002__cache-cli-with-config-flag

Conversation

@RandomGenericUsername
Copy link
Copy Markdown
Owner

@RandomGenericUsername RandomGenericUsername commented Mar 24, 2026

Ticket

  • Ticket ID:
  • User Story / Bug Report / Chore Description exists and is complete
  • Technical Document exists and is complete

Description

Type of Change

  • Feature (new functionality)
  • Bug fix (fixes an issue)
  • Documentation (docs only)
  • Refactor (code improvement, no behavior change)
  • Performance improvement
  • Hotfix (critical production issue)
  • Infrastructure/tooling

Related Issues

Closes #
Related to #

Design Compliance Checklist

Testing

  • Coverage ≥ 95% (verify: make test-all)
  • Unit tests for new/modified code
  • Integration tests for end-to-end flows (if applicable)
  • All tests pass locally (make test-all)
  • No flaky tests introduced

Documentation

  • CHANGELOG.md updated with user-facing changes
  • Public APIs have docstrings
  • User documentation updated (if user-facing change)
  • Development docs updated (if process changed)

Git Workflow

  • Branch name follows convention (feature/, bugfix/, docs/*, etc.)
  • Commits follow Conventional Commits format
  • No merge commits (rebased on target branch)

Code Quality

  • Code follows existing patterns and conventions
  • No commented-out code or debug statements
  • No TODO comments (convert to issues instead)
  • Error messages are clear and actionable

CI/CD

  • All CI checks passing
  • Linting passes: make lint
  • Security scan clean: make security
  • Tests pass with ≥95% coverage: make test-all

Security

  • No hardcoded secrets or credentials
  • Input validation for user-provided data
  • No command injection vulnerabilities
  • External dependencies reviewed

Verification Commands

make lint
make test-all
make pipeline

Breaking Changes

  • No breaking changes
  • Breaking changes documented with migration guide

Self-Review Checklist

  • I have reviewed my own code
  • I have tested this thoroughly
  • I have updated CHANGELOG.md
  • This PR is ready for review

RandomGenericUsername and others added 3 commits March 23, 2026 21:44
@RandomGenericUsername @claude
docs(FR-00002): add user story and tech spec for cache CLI with --con…
60a40b8 
…fig flag

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@RandomGenericUsername @claude
feat(FR-00002): add self-contained CLI to cache package
389f0ab 
- Embed StorageSettings in CacheSettings so one config file covers both
  cache behaviour and the storage backend
- Add defaults.toml (SQLite at ~/.local/share/core-cache/cache.db)
- Add config_file param to get_settings(), mirroring FR-00001 pattern
- Build core-cache CLI with --config flag and lookup/invalidate/clear commands
- Register core-cache entry point in pyproject.toml

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@RandomGenericUsername @claude
test(FR-00002): add CLI and settings tests for cache package
8769943 
- test_cli.py: full coverage of configure_cache callback, lookup,
  invalidate and clear commands including error paths
- test_settings.py: cover new storage field and config_file param

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@RandomGenericUsername RandomGenericUsername merged commit ce0676e into master Mar 24, 2026
12 checks passed
@RandomGenericUsername RandomGenericUsername deleted the FR-00002__cache-cli-with-config-flag branch March 24, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RandomGenericUsername