Skip to content

Fr 00001 storage config file flag#3

Merged
RandomGenericUsername merged 4 commits intomasterfrom
FR-00001__storage-config-file-flag
Mar 24, 2026
Merged

Fr 00001 storage config file flag#3
RandomGenericUsername merged 4 commits intomasterfrom
FR-00001__storage-config-file-flag

Conversation

@RandomGenericUsername
Copy link
Copy Markdown
Owner

Ticket

  • Ticket ID:
  • User Story / Bug Report / Chore Description exists and is complete
  • Technical Document exists and is complete

Description

Type of Change

  • Feature (new functionality)
  • Bug fix (fixes an issue)
  • Documentation (docs only)
  • Refactor (code improvement, no behavior change)
  • Performance improvement
  • Hotfix (critical production issue)
  • Infrastructure/tooling

Related Issues

Closes #
Related to #


Design Compliance Checklist

Testing

  • Coverage ≥ 95% (verify: make test-all)
  • Unit tests for new/modified code
  • Integration tests for end-to-end flows (if applicable)
  • All tests pass locally (make test-all)
  • No flaky tests introduced

Documentation

  • CHANGELOG.md updated with user-facing changes
  • Public APIs have docstrings
  • User documentation updated (if user-facing change)
  • Development docs updated (if process changed)

Git Workflow

  • Branch name follows convention (feature/, bugfix/, docs/*, etc.)
  • Commits follow Conventional Commits format
  • No merge commits (rebased on target branch)

Code Quality

  • Code follows existing patterns and conventions
  • No commented-out code or debug statements
  • No TODO comments (convert to issues instead)
  • Error messages are clear and actionable

CI/CD

  • All CI checks passing
  • Linting passes: make lint
  • Security scan clean: make security
  • Tests pass with ≥95% coverage: make test-all

Security

  • No hardcoded secrets or credentials
  • Input validation for user-provided data
  • No command injection vulnerabilities
  • External dependencies reviewed

Verification Commands

make lint
make test-all
make pipeline

Breaking Changes

  • No breaking changes
  • Breaking changes documented with migration guide

Self-Review Checklist

  • I have reviewed my own code
  • I have tested this thoroughly
  • I have updated CHANGELOG.md
  • This PR is ready for review

RandomGenericUsername and others added 4 commits March 23, 2026 21:10
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds --config / -c option to pass an explicit settings file path,
bypassing cwd-based project-root auto-discovery. The explicit config
layer sits above XDG user config but below env vars and CLI flags,
preserving the existing priority model.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
End-to-end CLI tests covering: --help baseline, --config loading,
set/get/exists/list/delete/clear round-trips, --config overrides
project-root auto-discovery, and invalid path rejection.

Workflow triggers on packages/storage/** changes only.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@RandomGenericUsername RandomGenericUsername merged commit 983f436 into master Mar 24, 2026
7 checks passed
@RandomGenericUsername RandomGenericUsername deleted the FR-00001__storage-config-file-flag branch March 24, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant