[CK_TILE]: PreshuffleB + PreshuffleBQuant for ABQuant pipeline#3687
Closed
ErwinTerpstra wants to merge 8 commits intodevelopfrom
Closed
[CK_TILE]: PreshuffleB + PreshuffleBQuant for ABQuant pipeline#3687ErwinTerpstra wants to merge 8 commits intodevelopfrom
ErwinTerpstra wants to merge 8 commits intodevelopfrom
Conversation
ErwinTerpstra
force-pushed
the
eterpstr/preshuffle-bquant-for-abquant-preshuffleb
branch
from
2b0aeef to
99264c6
Compare
ErwinTerpstra
changed the title
ErwinTerpstra
requested review from
Snektron,
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
poyenc,
qianfengz,
shumway,
tenpercent,
vidyasagar-amd and
vpietila-amd
as code owners
ThomasNing
reviewed
Feb 3, 2026
| static constexpr index_t NPerBlock = BlockGemmShape::kN; | ||
| static constexpr index_t KPerBlock = BlockGemmShape::kK; | ||
|
|
||
| static constexpr index_t NPerBlockBQ = (BQuantGroupSize::kN <= KPerBlock) |
Contributor
There was a problem hiding this comment.
Could I know why we put kN <= KPerblock
Contributor
Author
There was a problem hiding this comment.
Well spotted, that should indeed be NPerBlock.
7 tasks
Contributor
|
Imported to ROCm/rocm-libraries |
ThomasNing
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Feb 10, 2026
## Proposed changes Implement BQuantPreshuffle option for the ABQuant PreshuffleB pipeline. ## Checklist Please put an `x` into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask. - [X] I have added tests relevant to the introduced functionality, and the unit tests are passing locally - [X] I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, **IF** the test takes more than 30 seconds to run. - [X] I have added inline documentation which enables the maintainers with understanding the motivation - [X] I have removed the stale documentation which is no longer relevant after this pull request - [ ] (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request - [X] I have run `clang-format` on all changed files - [X] Any dependent changes have been merged --- 🔁 Imported from [ROCm/composable_kernel#3687](ROCm/composable_kernel#3687) 🧑💻 Originally authored by @ErwinTerpstra --------- Co-authored-by: Erwin Terpstra <erwin.terpstra@streamhpc.com> Co-authored-by: systems-assistant[bot] <systems-assistant[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implement BQuantPreshuffle option for the ABQuant PreshuffleB pipeline.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed files