Route Yjs awareness over the ywidget comm#24
Merged
martinRenou merged 3 commits intoQuantStack:mainfrom Apr 7, 2026
Merged
Conversation
5 tasks
martinRenou
requested changes
Apr 3, 2026
davidbrochart
approved these changes
Apr 7, 2026
Member
davidbrochart
left a comment
davidbrochart
left a comment
There was a problem hiding this comment.
Just nitpicking, but looks good otherwise.
Member
|
Thanks for the review. Happy to make a 0.5.0 with this once it's in. |
Co-authored-by: David Brochart <david.brochart@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the notebook-side Yjs comm bridge so it handles awareness updates in addition to the existing document sync / update traffic.
YCommProviderencodes outbound awareness changes and applies inbound awareness buffers. It can reuse an existing Awareness for the shared Y.Doc or create one when none is supplied, and only destroys awareness it owns.IJupyterYModel/JupyterYModelexpose optional awareness (default: none),JupyterYWidgetManagerpasses that intoYCommProviderwhen the comm opens.